test(calling): add voicemail playwright coverage#5091
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a1a8d38dfe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| await page.locator(CALLING_SELECTORS.VOICEMAIL_BTN).click({timeout: AWAIT_TIMEOUT}); | ||
| await expect(page.locator(`${CALLING_SELECTORS.VOICEMAIL_TABLE} th`)).toHaveCount(4, { |
There was a problem hiding this comment.
Handle non-UCM voicemail rendering before using the UI
On Webex Calling/BroadWorks projects, this click runs the sample app's non-UCM createVoiceMail() path; in docs/samples/calling/app.js:1373-1377 data.voicemailList is assigned to an array and then read as voicemailList.voicemailList.length, so the handler throws before adding table headers or rows. The new suite calls this helper unconditionally after the API poll finds a message, so WXC/BWRKS runs will time out waiting for the voicemail table unless the sample renderer is fixed or the test bypasses that broken branch for those backends.
Useful? React with 👍 / 👎.
| await page.locator(CALLING_SELECTORS.VOICEMAIL_FETCH_LIST_BTN).click({timeout: AWAIT_TIMEOUT}); | ||
| await expect(page.locator(CALLING_SELECTORS.VOICEMAIL_TABLE_ROWS)).toHaveCount(limit, { |
There was a problem hiding this comment.
Render pagination results before counting rows
This helper clears #voicemailTable and then clicks the pagination button, but the sample page handler fetchVoicemailList() only calls voicemail.getVoicemailList(...) and logs the response (docs/samples/calling/app.js:1642-1655); it never rebuilds the table. In VM-CALL-001 the subsequent row count therefore times out even when the backend returned one voicemail, so the helper needs to populate the table from the API response or use a UI path that actually renders the requested page.
Useful? React with 👍 / 👎.
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
COMPLETES #https://jira-eng-sjc12.cisco.com/jira/browse/CAI-7879
This pull request addresses
Adds Playwright E2E coverage for the Webex Calling voicemail flow. The test validates that an unanswered call can create a voicemail, the callee can list and play the voicemail, mark/read state is reflected in the UI, pagination fetch works, and the fetched paginated voicemail can also be played before cleanup.
by making the following changes
SET_VOICEMAILPlaywright project and user-set configuration.Change Type
The following scenarios were tested
The GAI Coding Policy And Copyright Annotation Best Practices
I certified that