Skip to content

fix(incoming-task): fix-incoming-task-overflow-issue #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkesavan13 merged 5 commits into from
Jul 3, 2025
Merged

fix(incoming-task): fix-incoming-task-overflow-issue #482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
66fa834
fix(incoming-task): fix-incoming-task-overflow-issue
akulakum Jun 30, 2025
2828c54
Merge branch 'ccwidgets' of github.com:webex/widgets into IC_TASK_OVE…
akulakum Jul 1, 2025
2aec8c7
fix(incoming-task): fix-incoming-task-overflow-issue-using-ellipsis
akulakum Jul 2, 2025
17e76b4
fix(incoming-task): removed-important-keyword-from-styles
akulakum Jul 3, 2025
23aaa0a
Merge branch 'ccwidgets' into IC_TASK_OVERRIDE_STYLE_ISSUE
akulakum Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
95 changes: 95 additions & 0 deletions ...tact-center/cc-components/src/components/task/CallControlCAD/call-control-cad.styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,4 +116,99 @@
.media-icon.chat {
color: var(--mds-color-theme-indicator-secure);
}
}
.call-control-task-tooltip::part(popover-content) {

@adhmenon adhmenon Jul 3, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious - we are using custom styles here - UX is alright with the changes correct?

@akulakum akulakum Jul 3, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we are overriding the Momentum default styles here to enable text wrapping for the tooltip. UX has reviewed and is okay with these custom style changes.

white-space: normal;
word-break: break-all;
}

.call-control-task-tooltip {
min-width: 30%;
width: auto;
text-align: center;
}

.digital-customer-name::part(text),
.voice-customer-name::part(text),
.digital-phone-number::part(text),
.voice-phone-number::part(text) {
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
margin: 0;
}

.digital-customer-name {
width: auto;
}

.digital-phone-number {
width: auto;
}

@media (min-width: 64.0625rem) and (max-width: 75rem) {
.digital-customer-name {
width: 50rem;
max-width: 50rem;
}

.digital-phone-number {
width: 16rem;
max-width: 16rem;
}
}

@media (min-width: 48.0625rem) and (max-width: 64rem) {
.digital-customer-name {
width: 31.25rem;
max-width: 31.25rem;
}

.digital-phone-number {
width: 15rem;
max-width: 15rem;
}
.call-control-task-tooltip {
width: 50%;
text-align: center;
}
}

@media (min-width: 30.0625rem) and (max-width: 48rem) {
.digital-customer-name {
width: 15.625rem;
max-width: 15.625rem;
}

.digital-phone-number {
width: 13rem;
max-width: 13rem;
}
.call-control-task-tooltip {
width: 50%;
text-align: center;
}
}

@media (min-width: 20rem) and (max-width: 30.0625rem) {
.digital-customer-name {
width: 9.375rem;
max-width: 9.375rem;
}

.digital-phone-number {
width: 12rem;
max-width: 12rem;
}
.call-control-task-tooltip {
width: 50%;
text-align: center;
}
}

@media (min-width: 15.625rem) and (max-width: 20rem){
.call-control-task-tooltip {
width: 50%;
text-align: center;
}
}
92 changes: 84 additions & 8 deletions ...ages/contact-center/cc-components/src/components/task/CallControlCAD/call-control-cad.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from 'react';
import CallControlComponent from '../CallControl/call-control';
import {Text} from '@momentum-ui/react-collaboration';
import {Brandvisual, Icon} from '@momentum-design/components/dist/react';
import {Brandvisual, Icon, Tooltip} from '@momentum-design/components/dist/react';
import './call-control-cad.styles.scss';
import TaskTimer from '../TaskTimer/index';
import CallControlConsultComponent from '../CallControl/CallControlCustom/call-control-consult';
Expand Down Expand Up @@ -60,6 +60,87 @@ const CallControlCADComponent: React.FC<CallControlComponentProps> = (props) =>
const customerName = currentTask?.data?.interaction?.callAssociatedDetails?.customerName;
const ani = currentTask?.data?.interaction?.callAssociatedDetails?.ani;

// Create unique IDs for tooltips
const customerNameTriggerId = `customer-name-trigger-${currentTask.data.interaction.interactionId}`;
const customerNameTooltipId = `customer-name-tooltip-${currentTask.data.interaction.interactionId}`;
const phoneNumberTriggerId = `phone-number-trigger-${currentTask.data.interaction.interactionId}`;
const phoneNumberTooltipId = `phone-number-tooltip-${currentTask.data.interaction.interactionId}`;

const renderCustomerName = () => {
const customerText = isSocial ? customerName || NO_CUSTOMER_NAME : ani || NO_CALLER_ID;

const textComponent = (
<Text
className={!isTelephony ? 'digital-customer-name' : 'voice-customer-name'}
type="body-large-bold"
tagName={'p'}
id={!isTelephony ? customerNameTriggerId : undefined}
>
{customerText}
</Text>
);

if (!isTelephony) {
return (
<>
{textComponent}
<Tooltip
color="contrast"
delay="0,0"
id={customerNameTooltipId}
placement="top-start"
offset={4}
tooltip-type="description"
triggerID={customerNameTriggerId}
className="call-control-task-tooltip"
>
<Text tagName="small">{customerText}</Text>
</Tooltip>
</>
);
}

return textComponent;
};

const renderPhoneNumber = () => {
const phoneText = isSocial ? customerName || NO_CUSTOMER_NAME : ani || NO_PHONE_NUMBER;
const labelText = isSocial ? CUSTOMER_NAME : PHONE_NUMBER;

const textComponent = (
<Text
className={!isTelephony ? 'digital-phone-number' : 'voice-phone-number'}
type="body-secondary"
tagName={'p'}
id={!isTelephony ? phoneNumberTriggerId : undefined}
>
<strong>{labelText}</strong> <span>{phoneText}</span>
</Text>
);

if (!isTelephony) {
return (
<>
{textComponent}
<Tooltip
color="contrast"
delay="0,0"
id={phoneNumberTooltipId}
placement="top-start"
offset={4}
tooltip-type="description"
triggerID={phoneNumberTriggerId}
className="call-control-task-tooltip"
>
<Text tagName="small">{phoneText}</Text>
</Tooltip>
</>
);
}

return textComponent;
};

if (!currentTask) return null;

return (
Expand All @@ -76,9 +157,7 @@ const CallControlCADComponent: React.FC<CallControlComponentProps> = (props) =>
</div>

<div className="customer-info">
<Text className="customer-id" type="body-large-bold" tagName={'small'}>
{isSocial ? customerName || NO_CUSTOMER_NAME : ani || NO_CALLER_ID}
</Text>
{renderCustomerName()}
<div className="call-details">
<Text className="call-timer" type="body-secondary" tagName={'small'}>
{currentMediaType.labelName} - <TaskTimer startTimeStamp={startTimestamp} />
Expand Down Expand Up @@ -110,10 +189,7 @@ const CallControlCADComponent: React.FC<CallControlComponentProps> = (props) =>
<strong>{QUEUE}</strong>{' '}
<span>{currentTask?.data?.interaction?.callAssociatedDetails?.virtualTeamName || NO_TEAM_NAME}</span>
</Text>
<Text className="phone-number" type="body-secondary" tagName={'small'}>
<strong>{isSocial ? CUSTOMER_NAME : PHONE_NUMBER}</strong>{' '}
<span> {isSocial ? customerName || NO_CUSTOMER_NAME : ani || NO_PHONE_NUMBER}</span>
</Text>
{renderPhoneNumber()}
<Text className="rona" type="body-secondary" tagName={'small'}>
<strong>{RONA}</strong>{' '}
<span>{currentTask?.data?.interaction?.callAssociatedDetails?.ronaTimeout || NO_RONA}</span>
Expand Down
60 changes: 53 additions & 7 deletions packages/contact-center/cc-components/src/components/task/Task/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React from 'react';
import {ButtonPill, ListItemBase, ListItemBaseSection, Text} from '@momentum-ui/react-collaboration';
import {Avatar, Brandvisual} from '@momentum-design/components/dist/react';
import {Avatar, Brandvisual, Tooltip} from '@momentum-design/components/dist/react';
import {PressEvent} from '@react-types/shared';
import TaskTimer from '../TaskTimer';
import {getMediaTypeInfo} from '../../../utils';
Expand Down Expand Up @@ -50,6 +50,57 @@ const Task: React.FC<TaskProps> = ({
return str.replace(/^\s*(\w)/, (match, firstLetter) => firstLetter.toUpperCase());
};
const currentMediaType = getMediaTypeInfo(mediaType, mediaChannel);
const isNonVoiceMedia = currentMediaType.labelName !== 'Call';
// Create unique IDs for tooltip trigger and tooltip
const tooltipTriggerId = `tooltip-trigger-${interactionId}`;
const tooltipId = `tooltip-${interactionId}`;
// Helper function to get the correct CSS class
const getTitleClassName = () => {
if (isNonVoiceMedia && isIncomingTask) {
return 'incoming-digital-task-title';
}
if (isNonVoiceMedia && !isIncomingTask) {
return 'task-digital-title';
}
return 'task-title';
};
const renderTitle = () => {
if (!title) return null;

const textComponent = (
<Text
tagName="span"
type={selected ? 'body-large-bold' : 'body-large-medium'}
className={getTitleClassName()}
id={isNonVoiceMedia ? tooltipTriggerId : undefined}
>
{title}
</Text>
);

if (isNonVoiceMedia) {
return (
<>
{textComponent}
<Tooltip
color="contrast"
delay="0,0"
id={tooltipId}
placement="top-start"
offset={4}
tooltip-type="description"
triggerID={tooltipTriggerId}
className="task-tooltip"
>
{title}
</Tooltip>
</>
);
}

return textComponent;
};

return (
<ListItemBase
className={`task-list-item ${selected ? 'task-list-item--selected' : ''} ${styles}`}
Expand All @@ -68,12 +119,7 @@ const Task: React.FC<TaskProps> = ({

<ListItemBaseSection position="fill">
<section className="task-details">
{title && (
<Text tagName="span" type={selected ? 'body-large-bold' : 'body-large-medium'}>
{title}
</Text>
)}

{renderTitle()}
{state && !isIncomingTask && (
<Text tagName="span" type="body-midsize-regular" className="task-text">
{capitalizeFirstWord(state)}
Expand Down
Loading
Loading