fix(cc-samples): refresh page onCCSignout#489
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
|
||
| const onCCSignOut = () => { | ||
| console.log('CC Sign out has been successful'); | ||
| window.location.reload(); |
There was a problem hiding this comment.
Since this is a react app, do we need to reload a page like this? This re-rendering should have been handled via the state itself, right?
There was a problem hiding this comment.
The idea is that during this call back, a connector app using the widget would entirely logout and go to the sign in page which means on coming back to the home page, the app is fresh as a page reload.
We are not trying to sign out and do just the refresh so as to maintain and reuse the token.
rarajes2
left a comment
There was a problem hiding this comment.
Please address the comment
# [1.28.0-ccwidgets.86](v1.28.0-ccwidgets.85...v1.28.0-ccwidgets.86) (2025-07-04) ### Bug Fixes * **cc-samples:** refresh page onCCSignout ([#489](#489)) ([22e4ee4](22e4ee4))
|
🎉 This PR is included in version 1.28.0-ccwidgets.86 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
COMPLETES Ad-hoc
This pull request addresses
OnCCSignoutis supposed to logout of webex (in the sample app case, refresh the page) and the users are supposed to login again, init widgets and start over. At the moment, it just does the station signout & deregister. The Station Login widget just stays there and lets people think we would be able to login again which is not true.by making the following changes
This PR addresses it by refreshing the page to start over
onCCSignoutScreen Recording
https://app.vidcast.io/share/3c0c7eaa-5cb9-405a-b40b-035d78d58ca3
Change Type
The following scenarios were tested
The GAI Coding Policy And Copyright Annotation Best Practices
Checklist before merging