Skip to content

fix(cc-components): fix user-state broken UI#496

Closed
Shreyas281299 wants to merge 1 commit into
webex:ccwidgetsfrom
Shreyas281299:user-state-ui-fix
Closed

fix(cc-components): fix user-state broken UI#496
Shreyas281299 wants to merge 1 commit into
webex:ccwidgetsfrom
Shreyas281299:user-state-ui-fix

Conversation

@Shreyas281299

@Shreyas281299 Shreyas281299 commented Jul 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

COMPLETES #< INSERT LINK TO ISSUE >

This pull request addresses

< DESCRIBE THE CONTEXT OF THE ISSUE >

by making the following changes

< DESCRIBE YOUR CHANGES >

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

  • The testing is done with the amplify link
    < ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - specify)
    • Github Copilot
    • Other - Please Specify
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

Checklist before merging

  • I have not skipped any automated checks
  • All existing and new tests passed
  • I have updated the testing document

@coderabbitai

coderabbitai Bot commented Jul 14, 2025

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Shreyas281299
Shreyas281299 commented Jul 14, 2025
View reviewed changes
Comment thread packages/contact-center/cc-components/src/components/UserState/user-state.tsx
<Item key={item.id} textValue={item.name} data-testid={`state-item-${item.name}`}>
<div
className="item-container"
data-testid={`item-container ${shouldHighlight ? `selected ${getIconStyle(item).class}` : ''}`}

@Shreyas281299 Shreyas281299 Jul 14, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldHighlight was broken because while working on the playwirhgt test I moved the check to data-testId rather than the class

Shreyas281299
Shreyas281299 commented Jul 14, 2025
View reviewed changes
Comment thread packages/contact-center/cc-components/src/components/UserState/user-state.utils.ts
return {class: 'available', iconName: 'recents-presence-filled'};
case AgentUserState.RONA:
return {class: 'rona', iconName: 'warning-filled'};
export const getIconStyle = (item): {class: string; iconName: string} => {

@Shreyas281299 Shreyas281299 Jul 14, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved all the implementation to the original code that was, AI did some optimization eventually breaking the functionality. Copied the original code and pasted

Shreyas281299
Shreyas281299 commented Jul 14, 2025
View reviewed changes
Comment thread ...t-center/cc-components/tests/components/UserState/__snapshots__/user-state.snapshot.tsx.snap
<div
class="item-container"
data-testid="item-container selected idle"
class="item-container selected idle"

@Shreyas281299 Shreyas281299 Jul 14, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated snapshot

@aws-amplify-us-east-2

aws-amplify-us-east-2 Bot commented Jul 14, 2025

Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-496.d1b38q61t1z947.amplifyapp.com

@Shreyas281299 Shreyas281299 added validated Indicates that the PR is ready for actions run_e2e Add this label to run E2E test for meeting and CC widgets labels Jul 14, 2025
@Shreyas281299

Shreyas281299 commented Aug 11, 2025

Copy link
Copy Markdown
Contributor Author

Fixed as part of -#511

@Shreyas281299
Shreyas281299 deleted the user-state-ui-fix branch September 16, 2025 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

run_e2e Add this label to run E2E test for meeting and CC widgets validated Indicates that the PR is ready for actions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Shreyas281299