fix(widgets): fixed-consult-transfer-popover-transient-issue by adhmenon · Pull Request #506 · webex/widgets

adhmenon · 2025-07-25T05:11:48Z

COMPLETES #<CAI-6804>

This pull request addresses

We were observing a very strange issue in our consult and transfer popover, wherein on some cases (such as in the beta sample app, when consuming widgets or during running of the chrome end to end tests) we were not getting the popover to show up.
This issue was extremely transient and depended on the browser, bundler and was difficult to pin point.

by making the following changes

After triaging, the issue was found to be due to a dependency library tippy.js, which was getting some kind of event interference on certain browsers due to difference in timings in DOM rendering, hence the transient changes of the issue.
Now we have moved the rendering of popover contents, ie. calling of loadBuddyAgents and loadQueues inside of a callback of tippy.js ie, onShow().
This ensures that all state management is handled by tippy.js and it works in all cases.

Note - Unit tests have been skipped, as I believe they will be handled by another ticket.

Vidcasts

Working in Widgets Sample App
https://app.vidcast.io/share/1d77c33b-3b3b-4364-b632-8725222e5a73

Working in Beta Sample App (Where it failed before)
https://app.vidcast.io/share/4e07b6d7-95da-4e21-b846-d4bbd1eda103

Change Type

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation update
Tooling change
Internal code refactor

The following scenarios were tested

The testing is done with the amplify link

Standard call accept and performed clicking of both transfer and consult buttons.
When Popover was opened, consulted and transfered to a Queue.

The GAI Coding Policy And Copyright Annotation Best Practices

Checklist before merging

I have not skipped any automated checks
All existing and new tests passed
I have updated the testing document

coderabbitai · 2025-07-25T05:11:54Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

adhmenon · 2025-07-25T05:13:14Z

    }
  };

-  const handlePopoverOpen = (menuType: CallControlMenuType) => {


No longer need these, have moved the handling to tippy state management.
Also, we were anyways calling the logic in the if block in the onHide, so removed that flow also as it was dead code.

aws-amplify-us-east-2 · 2025-07-25T05:17:12Z

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-506.d1b38q61t1z947.amplifyapp.com

mkesavan13

Changes look good to me. Approving.

Please resolve conflicts
Ensure the all the pipeline constraints including the E2E tests are passing

Plus, in the second Vidcast that is is not properly aligned. Why is that so? Is it because the page height is lesser?

adhmenon · 2025-07-25T06:29:29Z

Yes, regarding the alignment - our page height is not enough (it is the demo app and we did not test the popover hence we could not make changes).
Will merge conflicts.. however e2e tests - will look at them.. not sure why they fail.

Kesari3008

Please resolve the merge conflicts and e2e test failures for ccwidgets.
Also just checking if we tested consult/transfer after this change, thiugh it shouldnlt impact it but just to be sure.

…-consult-popover

adhmenon · 2025-07-25T09:34:20Z

    <ul className="task-list" data-testid="task-list">
      {Object.values(taskList)?.map((task, index) => {
-        //@ts-expect-error  To be fixed in SDK - https://jira-eng-sjc12.cisco.com/jira/browse/CAI-6762IT
+        //@ts-expect-error  To be fixed in SDK - https://jira-eng-sjc12.cisco.com/jira/browse/CAI-6762


Nit: Made this change while I was resolving merge conflicts.

# [1.28.0-ccwidgets.97](v1.28.0-ccwidgets.96...v1.28.0-ccwidgets.97) (2025-07-28) ### Bug Fixes * **widgets:** fixed-consult-transfer-popover-transient-issue ([#506](#506)) ([ae646bd](ae646bd))

sreenara · 2025-07-28T04:53:07Z

🎉 This PR is included in version 1.28.0-ccwidgets.97 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

fix(widgets): fixed-consult-transfer-popover-transient-issue

a8cc5d3

adhmenon added validated Indicates that the PR is ready for actions run_e2e Add this label to run E2E test for meeting and CC widgets labels Jul 25, 2025

adhmenon commented Jul 25, 2025

View reviewed changes

mkesavan13 approved these changes Jul 25, 2025

View reviewed changes

Kesari3008 approved these changes Jul 25, 2025

View reviewed changes

Merge branch 'ccwidgets' of https://github.com/webex/widgets into fix…

062c35b

…-consult-popover

adhmenon commented Jul 25, 2025

View reviewed changes

adhmenon merged commit ae646bd into webex:ccwidgets Jul 28, 2025
7 of 9 checks passed

adhmenon deleted the fix-consult-popover branch July 28, 2025 04:43

sreenara added the released on @ccwidgets label Jul 28, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(widgets): fixed-consult-transfer-popover-transient-issue#506

fix(widgets): fixed-consult-transfer-popover-transient-issue#506
adhmenon merged 2 commits into
webex:ccwidgetsfrom
adhmenon:fix-consult-popover

adhmenon commented Jul 25, 2025

Uh oh!

coderabbitai Bot commented Jul 25, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

adhmenon Jul 25, 2025

Uh oh!

aws-amplify-us-east-2 Bot commented Jul 25, 2025

Uh oh!

mkesavan13 left a comment

Uh oh!

adhmenon commented Jul 25, 2025

Uh oh!

Kesari3008 left a comment

Uh oh!

adhmenon Jul 25, 2025

Uh oh!

Uh oh!

sreenara commented Jul 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

adhmenon commented Jul 25, 2025

COMPLETES #<CAI-6804>

This pull request addresses

by making the following changes

Vidcasts

Change Type

The following scenarios were tested

The GAI Coding Policy And Copyright Annotation Best Practices

Checklist before merging

Uh oh!

coderabbitai Bot commented Jul 25, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

adhmenon Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

aws-amplify-us-east-2 Bot commented Jul 25, 2025

Uh oh!

mkesavan13 left a comment

Choose a reason for hiding this comment

Uh oh!

adhmenon commented Jul 25, 2025

Uh oh!

Kesari3008 left a comment

Choose a reason for hiding this comment

Uh oh!

adhmenon Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sreenara commented Jul 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants