Skip to content

fix(widgets): fixed-consult-transfer-popover-transient-issue #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adhmenon merged 2 commits into from
Jul 28, 2025
Merged

fix(widgets): fixed-consult-transfer-popover-transient-issue #506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8cc5d3
fix(widgets): fixed-consult-transfer-popover-transient-issue
adhmenon Jul 25, 2025
062c35b
Merge branch 'ccwidgets' of https://github.com/webex/widgets into fix…
adhmenon Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 10 additions & 17 deletions packages/contact-center/cc-components/src/components/task/CallControl/call-control.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,22 +150,6 @@ function CallControlComponent(props: CallControlComponentProps) {
}
};

const handlePopoverOpen = (menuType: CallControlMenuType) => {

@adhmenon adhmenon Jul 25, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer need these, have moved the handling to tippy state management.
Also, we were anyways calling the logic in the if block in the onHide, so removed that flow also as it was dead code.

logger.info('CC-Widgets: CallControl: opening call control popover', {
module: 'call-control.tsx',
method: 'handlePopoverOpen',
});
if (showAgentMenu && agentMenuType === menuType) {
setShowAgentMenu(false);
setAgentMenuType(null);
} else {
setAgentMenuType(menuType);
setShowAgentMenu(true);
loadBuddyAgents();
loadQueues();
}
};

const currentMediaType = getMediaTypeInfo(
currentTask.data.interaction.mediaType as MediaChannelType,
currentTask.data.interaction.mediaChannel as MediaChannelType
Expand Down Expand Up @@ -262,6 +246,16 @@ function CallControlComponent(props: CallControlComponentProps) {
return (
<PopoverNext
key={index}
onShow={() => {
logger.info(`CC-Widgets: CallControl: showing consult-transfer popover`, {
module: 'call-control.tsx',
method: 'onShowPopover',
});
setShowAgentMenu(true);
setAgentMenuType(button.menuType as CallControlMenuType);
loadBuddyAgents();
loadQueues();
}}
onHide={() => {
setShowAgentMenu(false);
setAgentMenuType(null);
Expand Down Expand Up @@ -293,7 +287,6 @@ function CallControlComponent(props: CallControlComponentProps) {
aria-label={button.tooltip}
disabled={button.disabled || (consultInitiated && isTelephony)}
data-testid={button.dataTestId}
onPress={() => handlePopoverOpen(button.menuType as CallControlMenuType)}
>
<Icon className={button.className + '-icon'} name={button.icon} />
</ButtonCircle>
Expand Down
2 changes: 1 addition & 1 deletion packages/contact-center/cc-components/src/components/task/TaskList/task-list.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const TaskListComponent: React.FunctionComponent<TaskListComponentProps> = (prop
return (
<ul className="task-list" data-testid="task-list">
{Object.values(taskList)?.map((task, index) => {
//@ts-expect-error To be fixed in SDK - https://jira-eng-sjc12.cisco.com/jira/browse/CAI-6762IT
//@ts-expect-error To be fixed in SDK - https://jira-eng-sjc12.cisco.com/jira/browse/CAI-6762

@adhmenon adhmenon Jul 25, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Made this change while I was resolving merge conflicts.

const callAssociationDetails = task?.data?.interaction?.callAssociatedDetails;
const ani = callAssociationDetails?.ani;
const customerName = callAssociationDetails?.customerName;
Expand Down
Loading