Skip to content

fix(cc-widgets): multi-stage consult flows#507

Merged
rsarika merged 6 commits into
webex:ccwidgetsfrom
mkesavan13:combination_advanced_task
Aug 6, 2025
Merged

fix(cc-widgets): multi-stage consult flows#507
rsarika merged 6 commits into
webex:ccwidgetsfrom
mkesavan13:combination_advanced_task

Conversation

@mkesavan13

@mkesavan13 mkesavan13 commented Jul 25, 2025

Copy link
Copy Markdown
Contributor

COMPLETES CAI-6526

This pull request addresses

Multistage consult test cases

by making the following changes

Originally wrote by @riteshfyi

Added 8 testcase for

From Agent1 To Agent2 From Agent2 To Agent1
Transfer via Agent Transfer via Agent
Consult via Agent Consult via Agent
Transfer via Agent Consult via Agent
Consult via Agent Transfer via Agent
Transfer via Queue NA
Consult via Queue NA

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

  • The testing is done with the amplify link
    < ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - specify)
    • Github Copilot
    • Other - Please Specify
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

Checklist before merging

  • I have not skipped any automated checks
  • All existing and new tests passed
  • I have updated the testing document

@coderabbitai

coderabbitai Bot commented Jul 25, 2025

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mkesavan13 mkesavan13 added validated Indicates that the PR is ready for actions run_e2e Add this label to run E2E test for meeting and CC widgets labels Jul 25, 2025
@riteshfyi

Copy link
Copy Markdown
Contributor

NOTE :
Transfer via Queue Transfer via Queue
Transfer via Queue Consult via Queue
Consult via Queue Consult via Queue
Consult via Queue Transfer via Queue

These test cases were replaced with a single multi-stage test.

@aws-amplify-us-east-2

Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-507.d1b38q61t1z947.amplifyapp.com

@mkesavan13

Copy link
Copy Markdown
Contributor Author

NOTE : Transfer via Queue Transfer via Queue Transfer via Queue Consult via Queue Consult via Queue Consult via Queue Consult via Queue Transfer via Queue

These test cases were replaced with a single multi-stage test.

Oh yes. Missed that.

But do you mean a single-stage test?

@riteshfyi

riteshfyi commented Jul 25, 2025

Copy link
Copy Markdown
Contributor

I meant a single Multi-Stage Test.

Suppose we have two agents A1 & A2.
When we transfer/consult Via Queue from A1 to A2, it works fine.
After that, when we try to consult/transfer via Queue from A2 & A1 (back to A1 again). The A1 doesn't get the task.
We have discussed regarding this on 17/07/25.
So that's why the above mentioned were removed.
I have added the below mentioned test in place of those.

Consult via Agent from A1 to A2 -> Transfer to A2, Consult back via Agent from A2 to A1-> transfer to A1 -> Consult via Agent from A1 to A2 -> cancel the consult.

@mkesavan13

Copy link
Copy Markdown
Contributor Author

I meant a single Multi-Stage Test.

Suppose we have two agents A1 & A2. When we transfer/consult Via Queue from A1 to A2, it works fine. After that, when we try to consult/transfer from A2 & A1 (back to A1 again). The A1 doesn't get the task. We have discussed regarding this on the 17/07/25. So that's why the above mentioned were removed. I have added the below mentioned test in place of those.

Consult via Agent from A1 to A2 -> Transfer to A2, Consult back via Agent from A2 to A1-> transfer to A1 -> Consult via Agent from A1 to A2 -> cancel the consult.

Thanks, @riteshfyi

import { pageSetup, waitForState } from "./Utils/helperUtils";
import { endTask } from "./Utils/taskControlUtils";

test.use({ headless: false });

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this line, it was being used only for convenience.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 18th only.

@rsarika
rsarika merged commit 5bb48ac into webex:ccwidgets Aug 6, 2025
7 of 9 checks passed
github-actions Bot pushed a commit that referenced this pull request Aug 6, 2025
# [1.28.0-ccwidgets.102](v1.28.0-ccwidgets.101...v1.28.0-ccwidgets.102) (2025-08-06)

### Bug Fixes

* **cc-widgets:** multi-stage consult flows ([#507](#507)) ([5bb48ac](5bb48ac))
@sreenara

sreenara commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.28.0-ccwidgets.102 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@mkesavan13
mkesavan13 deleted the combination_advanced_task branch February 17, 2026 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released on @ccwidgets run_e2e Add this label to run E2E test for meeting and CC widgets validated Indicates that the PR is ready for actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants