fix(cc-widgets): Incoming Transfer showing Call control fix by rsarika · Pull Request #510 · webex/widgets

rsarika · 2025-08-05T02:08:40Z

COMPLETES #507 https://jira-eng-sjc12.cisco.com/jira/browse/CAI-6889

This pull request addresses

Issue of showing call controls for incoming transfer before accepting call.

by making the following changes

Updated isIncomingTask logic in store and using it everywhere.

Change Type

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation update
Tooling change
Internal code refactor

The following scenarios were tested

Transfer, consult, consult transfer

The testing is done with the amplify link
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

The GAI Coding Policy And Copyright Annotation Best Practices

Checklist before merging

I have not skipped any automated checks
All existing and new tests passed
I have updated the testing document

…nsfer-issue

coderabbitai · 2025-08-05T02:08:45Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

aws-amplify-us-east-2 · 2025-08-05T02:13:58Z

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-510.d1b38q61t1z947.amplifyapp.com

…nsfer-issue

…nto transfer-issue

rarajes2 · 2025-08-07T09:12:32Z

  const taskState = task.data.interaction.state;
  const startTimeStamp = task.data.interaction.createdTimestamp;
-  const isIncomingTask = !task?.data.wrapUpRequired && (taskState === 'new' || taskState === 'consult');
+  const isIncomingTask = store.isIncomingTask(task);


As discussed, Let's export it outside the store object

rarajes2 · 2025-08-07T09:18:05Z

+      const taskWithoutJoined: ITask = {
+        data: {
+          interactionId: 'taskWithoutJoined',
+          interaction: {
+            state: 'connected',
+            participants: {
+              agent1: {
+                hasJoined: false,
+              },
+            },
+          },
+          agentId: 'agent1',
+        },
+      } as ITask;


Just a note: This is the case where we transfer the call but agent has not accepted it yet.

rarajes2 · 2025-08-07T09:19:01Z

    });
  });
+
+  it('renders TaskListPresentational with incoming task behavior when isIncomingTask returns true', () => {


Let's add snapshot tests.

its already tested in cc-components packages/contact-center/cc-components/tests/components/task/TaskList/task-list.tsx

// Verify selected task has buttons (incoming), unselected task doesn't (active)

rarajes2 · 2025-08-07T09:21:06Z

+    // Verify that `TaskListPresentational` is called with the correct props
+    expect(taskListComponentSpy).toHaveBeenCalledWith(
+      {
+        currentTask: undefined,


Let's have a currentTask and with incoming task check if the current task is unchanged.

its already tested in cc-components packages/contact-center/cc-components/tests/components/task/TaskList/task-list.tsx

// Verify selected task has buttons (incoming), unselected task doesn't (active)

rarajes2

Please address the last comment before merging.

rarajes2 · 2025-08-08T05:20:02Z

+export const isIncomingTask = (task: ITask): boolean => {
+  const taskData = task?.data;
+  const taskState = taskData?.interaction?.state;
+  const agentId = taskData?.agentId;
+  const participants = taskData?.interaction?.participants;
+  const hasJoined = agentId && participants?.[agentId]?.hasJoined;
+
+  return (
+    !taskData?.wrapUpRequired &&
+    !hasJoined &&
+    (taskState === 'new' || taskState === 'consult' || taskState === 'connected')
+  );
+};


We will need to create tests for this file as well, right?

# [1.28.0-ccwidgets.104](v1.28.0-ccwidgets.103...v1.28.0-ccwidgets.104) (2025-08-08) ### Bug Fixes * **cc-widgets:** Incoming Transfer showing Call control fix ([#510](#510)) ([25b3025](25b3025))

sreenara · 2025-08-08T05:53:55Z

🎉 This PR is included in version 1.28.0-ccwidgets.104 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

rsarika added 5 commits August 1, 2025 13:35

fix: tasklist in trasnfered cases

b87a0a6

fix: added test

a782d5d

Merge branch 'ccwidgets' of https://github.com/webex/widgets into tra…

78475c0

…nsfer-issue

Merge branch 'ccwidgets' of https://github.com/webex/widgets into tra…

e50d895

…nsfer-issue

fix: incoming Task logic updated

330b3c4

rsarika added validated Indicates that the PR is ready for actions run_e2e Add this label to run E2E test for meeting and CC widgets labels Aug 5, 2025

rsarika changed the title ~~fix(cc-widgets): Transfer issue Call control fix~~ fix(cc-widgets): Incoming Transfer showing Call control fix Aug 5, 2025

rsarika requested a review from Shreyas281299 August 5, 2025 08:58

akulakum approved these changes Aug 5, 2025

View reviewed changes

rsarika and others added 9 commits August 6, 2025 07:14

Merge branch 'ccwidgets' into transfer-issue

29bf7b9

Merge branch 'ccwidgets' of https://github.com/webex/widgets into tra…

e06c1d2

…nsfer-issue

Merge branch 'transfer-issue' of https://github.com/rsarika/widgets i…

a4f064c

…nto transfer-issue

Merge branch 'ccwidgets' into transfer-issue

d491760

fix: sdk version

608bb2b

fix: fixed incoming tests

5f3c589

fix: added timeouts to avoid indefinite waiting

72492a6

fix: timeout moved to constant

d066a1c

fix: removed unused file

709e8d5

rarajes2 reviewed Aug 7, 2025

View reviewed changes

Shreyas281299 approved these changes Aug 7, 2025

View reviewed changes

rsarika added 3 commits August 7, 2025 19:57

fix: addressed comments

9d77abf

fix: e2e tests updated

8b6222b

fix: removed unused

7273bfa

rarajes2 approved these changes Aug 8, 2025

View reviewed changes

fix: added tests for utils

dec188f

rsarika merged commit 25b3025 into webex:ccwidgets Aug 8, 2025
7 of 9 checks passed

sreenara added the released on @ccwidgets label Aug 8, 2025

Uh oh!

Conversation

rsarika commented Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

COMPLETES #507 https://jira-eng-sjc12.cisco.com/jira/browse/CAI-6889

This pull request addresses

by making the following changes

Change Type

The following scenarios were tested

The GAI Coding Policy And Copyright Annotation Best Practices

Checklist before merging

Uh oh!

coderabbitai Bot commented Aug 5, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

aws-amplify-us-east-2 Bot commented Aug 5, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rarajes2 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sreenara commented Aug 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rsarika commented Aug 5, 2025 •

edited

Loading