Skip to content

feat(cc-widgets): Transfer to dial number feature added#531

Merged
rsarika merged 7 commits into
webex:ccwidgetsfrom
rsarika:transfer_dial_number
Sep 16, 2025
Merged

feat(cc-widgets): Transfer to dial number feature added#531
rsarika merged 7 commits into
webex:ccwidgetsfrom
rsarika:transfer_dial_number

Conversation

@rsarika

@rsarika rsarika commented Sep 15, 2025

Copy link
Copy Markdown
Contributor

COMPLETES #https://jira-eng-sjc12.cisco.com/jira/browse/CAI-7080

This pull request addresses

Implement transfer/consult to DialNumber

by making the following changes

added one more tab DialNumber with one textbox and button.

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

Prerequisite: get a call from customer
transfer to dial number(use sreenara's number)
consult to dial number(use sreenara's number)
end consult before answers
consult to dial number(use sreenara's number)
end consult after answers
consult to dial number(use sreenara's number)
after answer consulttransfer

do the above steps for an entrypoint number as well eg: +16266820030

  • The testing is done with the amplify link
    < ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - specify)
    • Github Copilot
    • Other - Please Specify
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

Checklist before merging

  • I have not skipped any automated checks
  • All existing and new tests passed
  • I have updated the testing document

@rsarika
rsarika changed the base branch from master to ccwidgets September 15, 2025 09:52
@rsarika rsarika added validated Indicates that the PR is ready for actions run_e2e Add this label to run E2E test for meeting and CC widgets labels Sep 15, 2025

const noAgents = isAgentsEmpty(filteredAgents);
const noQueues = isQueuesEmpty(filteredQueues);
const showTabs = shouldShowTabs(filteredAgents, filteredQueues);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let us re-add this back, I think the below change was added for testing but we should ensure that we only show the tabs based on the list status... dial number tab can be present by default.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed 1:1 with Ravi - for now we show all tabs since we need to show dial number for everyone.

@adhmenon adhmenon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Let us test ocne with queue-dial.

handleQueueSelection(id, name, onQueueSelect, logger);
}
)}
{showTabs && selectedTab === 'DialNumber' && (

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create a constant for dialNumber

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queues and agents also

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed

startTimeStamp={consultStartTimeStamp}
endConsultCall={endConsultCall}
onTransfer={() => consultTransfer(consultAgentId || currentTask.data.destAgentId, lastTargetType)}
onTransfer={() => consultTransfer()}

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
onTransfer={() => consultTransfer()}
onTransfer={consultTransfer}

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed

@@ -282,10 +282,8 @@ export interface ControlProps {

/**
* Function to transfer the consult call to a destination.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update description

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed

@rsarika
rsarika requested a review from rarajes2 September 16, 2025 13:39

@mkesavan13 mkesavan13 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the minor comments from the sit-down review and we are good to merge

@rsarika
rsarika merged commit f7b1773 into webex:ccwidgets Sep 16, 2025
6 of 7 checks passed
github-actions Bot pushed a commit that referenced this pull request Sep 16, 2025
# [1.28.0-ccwidgets.114](v1.28.0-ccwidgets.113...v1.28.0-ccwidgets.114) (2025-09-16)

### Features

* **cc-widgets:** Transfer to dial number feature added ([#531](#531)) ([f7b1773](f7b1773))
@sreenara

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.28.0-ccwidgets.114 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released on @ccwidgets run_e2e Add this label to run E2E test for meeting and CC widgets validated Indicates that the PR is ready for actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants