-
Notifications
You must be signed in to change notification settings - Fork 70
feat(cc-widgets): Transfer to dial number feature added #531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e794edf
feat: added transfer/consult to dialNumber
rsarika 13fde22
fix: removed shouldShowTabs because we need to show always
rsarika d44b6ff
fix: updated tests
rsarika 93da7a3
fix: updated sdk version
rsarika 95380f6
fix: removed consultTransfer params
rsarika b580f5e
fix: updated sdk version
rsarika 9479562
fix: addressed comments
rsarika File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
19 changes: 19 additions & 0 deletions
19
...nents/src/components/task/CallControl/CallControlCustom/consult-transfer-dial-number.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| .consult-transfer-dial-number-container { | ||
| display: flex; | ||
| align-items: center; | ||
| gap: 8px; | ||
| width: 100%; | ||
| height: 40px; | ||
| } | ||
|
|
||
| .consult-transfer-dial-number-input { | ||
| flex: 1; | ||
| align-self: center; | ||
| display: flex; | ||
| align-items: center; | ||
| height: 100%; | ||
| } | ||
|
|
||
| .consult-transfer-dial-number-btn { | ||
| align-self: flex-start; | ||
| } |
35 changes: 35 additions & 0 deletions
35
...onents/src/components/task/CallControl/CallControlCustom/consult-transfer-dial-number.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| import React, {useState} from 'react'; | ||
| import './consult-transfer-dial-number.scss'; | ||
| import {ButtonCircle} from '@momentum-ui/react-collaboration'; | ||
| import {Icon, Input} from '@momentum-design/components/dist/react'; | ||
| import {ConsultTransferDialNumberComponentProps} from '../../task.types'; | ||
| import {handleButtonPress, onInputDialNumber} from '../call-control.utils'; | ||
|
|
||
| const DialNumberUI: React.FC<ConsultTransferDialNumberComponentProps> = (props) => { | ||
| const {buttonIcon, onButtonPress, logger} = props; | ||
|
|
||
| const [value, setValue] = useState(''); | ||
| return ( | ||
| <div className="consult-transfer-dial-number-container"> | ||
| <Input | ||
| id="dial-number-input" | ||
| data-testid="dial-number-input" | ||
| value={value} | ||
| onInput={(e) => onInputDialNumber(e, setValue)} | ||
| placeholder="Enter Dial Number" | ||
| className="consult-transfer-dial-number-input" | ||
| /> | ||
| <ButtonCircle | ||
| onPress={() => handleButtonPress(logger, onButtonPress, value)} | ||
| size={28} | ||
| color="join" | ||
| className="consult-transfer-dial-number-btn" | ||
| data-testid="dial-number-btn" | ||
| > | ||
| <Icon name={buttonIcon} /> | ||
| </ButtonCircle> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| export default DialNumberUI; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 29 additions & 0 deletions
29
...ntrol/CallControlCustom/__snapshots__/consult-transfer-dial-number.snapshot.test.tsx.snap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| // Jest Snapshot v1, https://goo.gl/fbAQLP | ||
|
|
||
| exports[`DialNumberUI snapshot matches snapshot 1`] = ` | ||
| <div> | ||
| <div | ||
| class="consult-transfer-dial-number-container" | ||
| > | ||
| <mdc-input | ||
| class="consult-transfer-dial-number-input" | ||
| data-testid="dial-number-input" | ||
| /> | ||
| <button | ||
| class="md-button-circle-wrapper consult-transfer-dial-number-btn md-button-simple-wrapper" | ||
| data-color="join" | ||
| data-disabled="false" | ||
| data-ghost="false" | ||
| data-inverted="false" | ||
| data-multiple-children="false" | ||
| data-outline="false" | ||
| data-shallow-disabled="false" | ||
| data-size="28" | ||
| data-testid="dial-number-btn" | ||
| type="button" | ||
| > | ||
| <mdc-icon /> | ||
| </button> | ||
| </div> | ||
| </div> | ||
| `; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let us re-add this back, I think the below change was added for testing but we should ensure that we only show the tabs based on the list status... dial number tab can be present by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed 1:1 with Ravi - for now we show all tabs since we need to show dial number for everyone.