Skip to content

fix(cc-widgets): E2e peding comments and new Dial number tests - #535

Merged
rsarika merged 8 commits into
webex:ccwidgetsfrom
rsarika:e2e-comments
Sep 29, 2025
Merged

fix(cc-widgets): E2e peding comments and new Dial number tests#535
rsarika merged 8 commits into
webex:ccwidgetsfrom
rsarika:e2e-comments

Conversation

@rsarika

@rsarika rsarika commented Sep 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

COMPLETES #https://jira-eng-sjc12.cisco.com/jira/browse/CAI-6845

This pull request addresses

adding tests for newly added dial number feature.

by making the following changes

added tests for newly added dial number feature. And made agent 1 as extension login to test combination

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

  • The testing is done with the amplify link
    < ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - specify)
    • Github Copilot
    • Other - Please Specify
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

Checklist before merging

  • I have not skipped any automated checks
  • All existing and new tests passed
  • I have updated the testing document

@rsarika rsarika added validated Indicates that the PR is ready for actions run_e2e Add this label to run E2E test for meeting and CC widgets labels Sep 17, 2025
@aws-amplify-us-east-2

aws-amplify-us-east-2 Bot commented Sep 17, 2025

Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-535.d1b38q61t1z947.amplifyapp.com

adhmenon
adhmenon reviewed Sep 23, 2025
View reviewed changes
Comment thread playwright/Utils/advancedTaskControlUtils.ts
* Utility function to get all captured logs for debugging purposes.
* @returns Array of all captured log messages
*/
export function getAllCapturedLogs(): string[] {

@adhmenon adhmenon Sep 23, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have we removed this? Do we not need it anymore?

@rsarika rsarika Sep 25, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. we were not using this anywhere in codebase

adhmenon
adhmenon reviewed Sep 25, 2025
View reviewed changes

@adhmenon adhmenon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
But I think we need not have this PR - with address book changes, I feel we will need different automation tests - those can be handled during a later stage.

adhmenon
adhmenon approved these changes Sep 26, 2025
View reviewed changes

@adhmenon adhmenon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disucssed 1:1 with Ravi.
This can go in, we will anyways clean it up with addressbook widgets PR.

@rsarika
rsarika merged commit f02eeed into webex:ccwidgets Sep 29, 2025
7 of 8 checks passed
github-actions Bot pushed a commit that referenced this pull request Sep 29, 2025
@semantic-release-bot
chore(release): 1.28.0-ccwidgets.116 [skip ci]
fcfb31e 
# [1.28.0-ccwidgets.116](v1.28.0-ccwidgets.115...v1.28.0-ccwidgets.116) (2025-09-29)

### Bug Fixes

* **cc-widgets:** E2e peding comments and new Dial number tests ([#535](#535)) ([f02eeed](f02eeed))
@sreenara

sreenara commented Sep 29, 2025

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.28.0-ccwidgets.116 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adhmenon adhmenon adhmenon approved these changes

Assignees

No one assigned

Labels

released on @ccwidgets run_e2e Add this label to run E2E test for meeting and CC widgets validated Indicates that the PR is ready for actions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rsarika @sreenara @adhmenon