fix(cc-widgets): e2e tests by rsarika · Pull Request #588 · webex/widgets

rsarika · 2025-12-18T17:29:31Z

COMPLETES #https://jira-eng-sjc12.cisco.com/jira/browse/CAI-7496

This pull request addresses

Fixing the e2e tests.
Added logging for better debug.

by making the following changes

move all the dial numbers tests into one suite.

Change Type

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation update
Tooling change
Internal code refactor

The following scenarios were tested

The testing is done with the amplify link
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

The GAI Coding Policy And Copyright Annotation Best Practices

Checklist before merging

I have not skipped any automated checks
All existing and new tests passed
I have updated the testing document
I have tested the functionality with amplify link

Make sure to have followed the contributing guidelines before submitting.

…tests

aws-amplify-us-east-2 · 2025-12-18T17:34:56Z

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-588.d1b38q61t1z947.amplifyapp.com

…tests

adhmenon

Mostly looks good.
Few doubts around timeout duration and some utils.

adhmenon · 2026-01-19T05:30:07Z

-      const incomingTaskDiv = testManager.agent1Page.getByTestId('samples:incoming-task-telephony').first();
-      await incomingTaskDiv.waitFor({state: 'visible', timeout: 80000});
-
+      await waitForIncomingTask(testManager.agent1Page, TASK_TYPES.CALL, 80000);


Question - do we need such a large timeout?

addressed by adding a constant with 60000

adhmenon · 2026-01-19T05:30:35Z

      );
-
+      // Agent 2 should receive the transfer and accept it
+      await acceptIncomingTask(testManager.agent2Page, TASK_TYPES.CALL, 60000);


Notice this timeout is different, have we added optimised values - is this why each are different?

addressed by adding a constant with 60000

adhmenon · 2026-01-19T06:29:26Z

+    await incomingChatTaskDiv.waitFor({state: 'visible', timeout: 40000});
    await acceptIncomingTask(testManager.agent1Page, TASK_TYPES.CHAT);
-    await incomingEmailTaskDiv.waitFor({state: 'visible', timeout: 3000});
+    await incomingEmailTaskDiv.waitFor({state: 'visible', timeout: 40000});


Do we need such large timeouts?

yes. email takes time to reach ui

adhmenon · 2026-01-19T06:31:29Z

      await hideDesktopCheckbox.click();
      await testManager.agent1Page.waitForTimeout(500);
-      await verifyDesktopOptionVisibility(testManager.agent1Page, true);
+      await verifyDesktopOptionVisibility(testManager.agent1Page, false);


WHy is this change needed?

because of default value and hideDesktopCheckbox visibility is false

adhmenon · 2026-01-19T06:33:20Z

-  test.afterAll(async () => {
-    await testManager.cleanup();
-  });
+  // No afterAll here - suite handles cleanup


Nit: can remove this.

adhmenon · 2026-01-19T06:34:12Z

 import {loginExtension} from './incomingTaskUtils';
 import {dismissOverlays} from './helperUtils';
-import {AWAIT_TIMEOUT, FORM_FIELD_TIMEOUT} from '../constants';
+import {AWAIT_TIMEOUT, FORM_FIELD_TIMEOUT, LONG_WAIT} from '../constants';


Nit: Maybe rename the LONG_WAIT to something else?

adhmenon · 2026-01-19T06:37:51Z

+    const endButton = page.getByTestId('call-control:end-call').first();
+    const endButtonVisible = await endButton.isVisible().catch(() => false);
+
+    if (endButtonVisible) {


Wondering why we had to do these end button checks for cleaning up stray tasks? Would they not be handled by the test itself?

this will be useful when some test fails and make sure other tests have clean state. and for the end button for extension or in hold state end button is disabled. so to clear that task we have to unhold before we click end

adhmenon · 2026-01-19T06:44:31Z

+              const endBtnAfterAccept = page.getByTestId('call-control:end-call').first();
+              const endVisibleAfterAccept = await endBtnAfterAccept.isVisible().catch(() => false);
+              if (endVisibleAfterAccept) {
+                const endEnabledAfterAccept = await endBtnAfterAccept.isEnabled().catch(() => false);
+                if (endEnabledAfterAccept) {


Why are we accepting tasks in the stray task cleanup?
I feel this should be handled in tests...

same to make suer other test have clean slate if at all some test fails .

Shreyas281299 · 2026-01-21T04:39:10Z

+            // Don't continue - fall through to check wrapup immediately
+          } else {
+          }
+        } catch (e) {


We can throw this error to ensure the tests fails.

this is to silently give clean slate for the tests and and wont affect any tests to throw error

Shreyas281299 · 2026-01-21T04:39:15Z

+          actionTaken = true;
+          await page.waitForTimeout(300);
+          continue;
+        } catch (e) {


Shreyas281299 · 2026-01-21T04:40:44Z

 */
-
 export const handleStrayTasks = async (
  page: Page,


Can we create sub method for this 300 lines method. It became very hard to follow

…tests

Shreyas281299 · 2026-01-21T05:04:26Z

    );
    // Ensure only one page remains in the Dial Number context to avoid duplicate web client instances
-    await this.enforceSingleDialNumberInOwnContext();
+    // await this.enforceSingleDialNumberInOwnContext();


Can we remove this if not required

Shreyas281299 · 2026-01-21T05:06:11Z

+    });
+    test.describe('Dial Number Tests', () => {
+      test.beforeAll(async () => {
+        test.skip(!process.env.PW_DIAL_NUMBER_NAME, 'PW_DIAL_NUMBER_NAME not set');


we can remove this, we are not doing anything here

…tests

fix: e2e tests

fa214a4

rsarika added validated Indicates that the PR is ready for actions run_e2e Add this label to run E2E test for meeting and CC widgets labels Dec 18, 2025

rsarika added 2 commits December 18, 2025 23:02

fix: test

50a4c98

Merge branch 'next' of https://github.com/webex/widgets into fix-e2e-…

ed706c0

…tests

rsarika and others added 15 commits December 18, 2025 23:46

fix: e2e tests

073c07f

fix: e2e tests stray task clear

6f88fc1

fix: e2e tests

df06b37

fix: updated queue name

9cab6ca

fix: added new set

2cae76c

fix: updated ccsdk version

d3199d4

Merge branch 'next' into fix-e2e-tests

cc5db4a

fix: e2e tests using calling sdk

d3577c8

fix: removed unused imports

d5f5536

Merge branch 'next' of https://github.com/webex/widgets into fix-e2e-…

88875a4

…tests

fix: removed unused function

7975897

fix: double element issue

8af0882

fix: dummy commit

a3c4b21

fix: removed logging as trace is enough

844fe1b

fix: updated multiple tasks test to avoid its flaky ness

8eb22f0

adhmenon reviewed Jan 19, 2026

View reviewed changes

Shreyas281299 reviewed Jan 21, 2026

View reviewed changes

rsarika added 2 commits January 21, 2026 10:17

fix: addressed comments

5236db9

Merge branch 'next' of https://github.com/webex/widgets into fix-e2e-…

86c3f29

…tests

Shreyas281299 approved these changes Jan 21, 2026

View reviewed changes

adhmenon approved these changes Jan 21, 2026

View reviewed changes

Merge branch 'next' of https://github.com/webex/widgets into fix-e2e-…

7f7d89d

…tests

rsarika merged commit 093124c into webex:next Jan 27, 2026
7 of 8 checks passed

Uh oh!

Conversation

rsarika commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

COMPLETES #https://jira-eng-sjc12.cisco.com/jira/browse/CAI-7496

This pull request addresses

by making the following changes

Change Type

The following scenarios were tested

The GAI Coding Policy And Copyright Annotation Best Practices

Checklist before merging

Uh oh!

aws-amplify-us-east-2 Bot commented Dec 18, 2025

Uh oh!

adhmenon left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rsarika Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rsarika commented Dec 18, 2025 •

edited

Loading

rsarika Jan 21, 2026 •

edited

Loading