Skip to content

fix(task): match OutdialCall UI with Figma - #589

Merged
mkesavan13 merged 4 commits into
webex:nextfrom
brain-frog:next
Jan 16, 2026
Merged

fix(task): match OutdialCall UI with Figma#589
mkesavan13 merged 4 commits into
webex:nextfrom
brain-frog:next

Conversation

@brain-frog

@brain-frog brain-frog commented Jan 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

COMPLETES https://jira-eng-sjc12.cisco.com/jira/browse/CAI-7509

This pull request addresses

Previous changes to the Outdial Call CSS have misaligned the containers within.

by making the following changes

Adjusting the HTML tags and class usage inside OutdialCall, as well as adding back some CSS properties to containers that lost them.

BEFORE
outdial-styling-issues

AFTER
Screenshot 2026-01-14 at 10 14 53 AM

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

  • The testing is done with the amplify link
    < ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - specify)
    • Github Copilot
    • Other - Please Specify
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

Checklist before merging

  • I have not skipped any automated checks
  • All existing and new tests passed
  • I have updated the testing document
  • I have tested the functionality with amplify link

Make sure to have followed the contributing guidelines before submitting.

@aws-amplify-us-east-2

aws-amplify-us-east-2 Bot commented Jan 5, 2026

Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-589.d1b38q61t1z947.amplifyapp.com

mkesavan13
mkesavan13 previously requested changes Jan 6, 2026
View reviewed changes

@mkesavan13 mkesavan13 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update the PR title to reflect the change as the PR title is what sits in the commit history.

@mkesavan13 mkesavan13 added the validated Indicates that the PR is ready for actions label Jan 6, 2026
akulakum
akulakum reviewed Jan 6, 2026
View reviewed changes

@akulakum akulakum left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please clarify which Figma design we are following to address the Outdial component design issue? Also, please attach the corresponding Figma link in the PR description.

@brain-frog brain-frog changed the title bug(task): Update OutdialCall CSS bug(task): Fix OutdialCall CSS to be consistent with Desktop visual Jan 6, 2026
@Shreyas281299 Shreyas281299 added validated Indicates that the PR is ready for actions and removed validated Indicates that the PR is ready for actions labels Jan 7, 2026
rsarika
rsarika approved these changes Jan 7, 2026
View reviewed changes

@rsarika rsarika left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the PR title and make sure the pipeline successful

@brain-frog brain-frog changed the title bug(task): Fix OutdialCall CSS to be consistent with Desktop visual fix(task): OutdialCall CSS Jan 7, 2026
@rsarika rsarika added validated Indicates that the PR is ready for actions and removed validated Indicates that the PR is ready for actions labels Jan 7, 2026
@akulakum

akulakum commented Jan 8, 2026

Copy link
Copy Markdown
Contributor

@brain-frog, the changes look good overall. To fully match the Figma design, the Address Book and Dialpad tab labels are missing, and the Dialpad tab background color needs to be updated. If you have bandwidth, please address these as well so the implementation aligns with Figma.

Screenshot 2026-01-08 at 10 04 46 AM

Shreyas281299
Shreyas281299 approved these changes Jan 8, 2026
View reviewed changes

@Shreyas281299 Shreyas281299 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good.

@akulakum

akulakum commented Jan 13, 2026

Copy link
Copy Markdown
Contributor

@brain-frog, the changes look good overall. To fully match the Figma design, the Address Book and Dialpad tab labels are missing, and the Dialpad tab background color needs to be updated. If you have bandwidth, please address these as well so the implementation aligns with Figma.

Screenshot 2026-01-08 at 10 04 46 AM

As per the design, we are intentionally not including text for the tabs. However, could we update the background color of the Dialpad tab? The current background does not match the Figma design.

Screenshot 2026-01-09 at 10 38 20 AM Screenshot 2026-01-09 at 10 43 39 AM

akulakum
akulakum approved these changes Jan 16, 2026
View reviewed changes

@akulakum akulakum left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkesavan13 mkesavan13 changed the title fix(task): OutdialCall CSS fix(task): match OutdialCall UI with Figma Jan 16, 2026
@mkesavan13
mkesavan13 dismissed their stale review January 16, 2026 05:01

I have updated the PR title myself

@mkesavan13
mkesavan13 merged commit 2341423 into webex:next Jan 16, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Shreyas281299 Shreyas281299 Shreyas281299 approved these changes
@akulakum akulakum akulakum approved these changes
@rsarika rsarika rsarika approved these changes
@mkesavan13 mkesavan13 mkesavan13 left review comments

Assignees

No one assigned

Labels

validated Indicates that the PR is ready for actions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@brain-frog @akulakum @mkesavan13 @Shreyas281299 @rsarika