fix(tooling): remove logs folder from gitignore - #607
Merged
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Contributor
Author
|
I tried to repopulate the lost changelogs but its too hard and I feel not worth the effort. Please let me know if we should fetch the older changelogs, this would required a ticket as its a longer effort [UPDATE]: A totla of 17 changelog entries are not present |
mkesavan13
approved these changes
Jan 28, 2026
mkesavan13
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the detailed description. Looks good to me.
- However, why was this ignored in the first place?
- What are the steps to bring back all the lost changelog?
bhabalan
approved these changes
Jan 28, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

COMPLETES #Adhoc
This pull request addresses
After #551, we move the repo to use github-actions for all the packages in the monorepo. Uptill that point we were using semantic-changelog to create our changelogs for the repo.
During that migration we also introduced package-tools that handles all the tooling for the repo including publishing and creation of changelogs. Now the new changelogs are being created under docs/changelog/logs. The issue is that we have
*logs*and*.jsonpresent in the .gitignore so the new changelogs created were never commited to the documentation branch and hence we dont see them in the changelogby making the following changes
Removed
*logs*and added a exception for all the jsons in the logs folder!docs/changelog/logs/*.json, to allow the logs to be commited after a publish.Change Type
The following scenarios were tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
The GAI Coding Policy And Copyright Annotation Best Practices
Checklist before merging
Make sure to have followed the contributing guidelines before submitting.