Skip to content

fix(tooling): remove logs folder from gitignore - #607

Merged
Shreyas281299 merged 2 commits into
webex:nextfrom
Shreyas281299:remove-log-gitignore
Jan 28, 2026
Merged

fix(tooling): remove logs folder from gitignore#607
Shreyas281299 merged 2 commits into
webex:nextfrom
Shreyas281299:remove-log-gitignore

Conversation

@Shreyas281299

@Shreyas281299 Shreyas281299 commented Jan 28, 2026

Copy link
Copy Markdown
Contributor

COMPLETES #Adhoc

This pull request addresses

After #551, we move the repo to use github-actions for all the packages in the monorepo. Uptill that point we were using semantic-changelog to create our changelogs for the repo.

During that migration we also introduced package-tools that handles all the tooling for the repo including publishing and creation of changelogs. Now the new changelogs are being created under docs/changelog/logs. The issue is that we have *logs* and *.json present in the .gitignore so the new changelogs created were never commited to the documentation branch and hence we dont see them in the changelog

by making the following changes

Removed *logs* and added a exception for all the jsons in the logs folder !docs/changelog/logs/*.json, to allow the logs to be commited after a publish.

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

  • The testing is done with the amplify link
    < ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - specify)
    • Github Copilot
    • Other - Please Specify
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

Checklist before merging

  • I have not skipped any automated checks
  • All existing and new tests passed
  • I have updated the testing document
  • I have tested the functionality with amplify link

Make sure to have followed the contributing guidelines before submitting.

@Shreyas281299 Shreyas281299 added the validated Indicates that the PR is ready for actions label Jan 28, 2026
@aws-amplify-us-east-2

Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-607.d1b38q61t1z947.amplifyapp.com

@Shreyas281299

Shreyas281299 commented Jan 28, 2026

Copy link
Copy Markdown
Contributor Author

I tried to repopulate the lost changelogs but its too hard and I feel not worth the effort. Please let me know if we should fetch the older changelogs, this would required a ticket as its a longer effort

[UPDATE]: A totla of 17 changelog entries are not present

@mkesavan13 mkesavan13 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the detailed description. Looks good to me.

  • However, why was this ignored in the first place?
  • What are the steps to bring back all the lost changelog?

@Shreyas281299

Shreyas281299 commented Jan 28, 2026

Copy link
Copy Markdown
Contributor Author
Screenshot 2026-01-28 at 6 46 55 PM
  • The ignore has been in place since gitignore was added, we missed to remove this

  • The issue with bringing back the older changelog is that when we create a changelog it looks at the latest commit on npm and pulls that, so now if I roll back to the commit and create the changelog it will always fetch the latest version (1.24.0-next.14), once thats done we now we would have to manually lookup in the github-actions logs and update each version manually in the changelog and repeat this process. It is definetly possible.

@Shreyas281299
Shreyas281299 merged commit a97dd1b into webex:next Jan 28, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

validated Indicates that the PR is ready for actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants