Up to date with next branch#717
Conversation
…able releases (webex#661) Co-authored-by: Bharath Balan <62698609+bhabalan@users.noreply.github.com> Co-authored-by: Kesava Krishnan Madavan <mkesavan13@gmail.com>
Co-authored-by: Shreyas Sharma <shreyassharma9912@gmail.com> Co-authored-by: Shreyas Sharma <72344404+Shreyas281299@users.noreply.github.com>
Co-authored-by: molker <molker@cisco.com>
Co-authored-by: Kesava Krishnan Madavan <mkesavan13@gmail.com>
Co-authored-by: ciscoRankush <ciscoRankush@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Rankush Kumar <rankkuma+cisco@cisco.com>
…coverage, and bug-fix pipeline (webex#636) Co-authored-by: Kesava Krishnan Madavan <mkesavan13@gmail.com>
…on [PSIRT-0974799192] (webex#676) Co-authored-by: Bharath Balan <62698609+bhabalan@users.noreply.github.com>
Co-authored-by: Christina Mullen <chrmulle@cisco.com>
…gn Select/Option (webex#665)
Co-authored-by: Matthew Olker <molker@cisco.com>
Co-authored-by: Christina Mullen <chrmulle@cisco.com>
…#695) Co-authored-by: Zach Raymer <zraymer@cisco.com> Co-authored-by: Kesava Krishnan Madavan <mkesavan13@gmail.com>
Resolve merge conflicts keeping uiControls migration while porting campaign preview, CallControlCAD caller ID, and store event fixes.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c7ca9f65fe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Inbound: ani = caller's number, dn = entry point dialed by caller | ||
| // Outdial: ani = agent's originating number (entry point), dn = customer's dialed number | ||
| const outboundType = currentTask?.data?.interaction?.outboundType; | ||
| const callerNumber = getCallerIdentifier(ani, dn, outboundType); |
There was a problem hiding this comment.
When an outdial task has the customer's dialed number in callAssociatedDetails.dnis or callProcessingDetails.dnis but does not populate callAssociatedDetails.dn, this now passes undefined as dn and getCallerIdentifier falls back to ani, which is the agent/entry-point number for outdial calls. The previous code, and the TaskList/IncomingTask utilities, preserve the dnis fallback, so those outdial calls will show the wrong caller identifier in CallControlCAD.
Useful? React with 👍 / 👎.
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
13 participants
COMPLETES #< INSERT LINK TO ISSUE >
This pull request addresses
< DESCRIBE THE CONTEXT OF THE ISSUE >
by making the following changes
< DESCRIBE YOUR CHANGES >
Change Type
The following scenarios were tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
The GAI Coding Policy And Copyright Annotation Best Practices
Checklist before merging
Make sure to have followed the contributing guidelines before submitting.