Make the legacy kernel a dedicated service, avoid creating services at compile-time

Author: mpdude

DependencyInjection/WebfactoryLegacyIntegrationExtension.php

@@ -35,17 +35,5 @@ public function load(array $configs, ContainerBuilder $container)
                 $container->setParameter('webfactory_legacy_integration.parser_class', 'Webfactory\Dom\XHTML10ParsingHelper');
                 break;
         }
-
-        if (isset($config['legacyApplicationBootstrapFile'])) {
-
-            $wrap = new Definition(
-                'Webfactory\Bundle\LegacyIntegrationBundle\Integration\BootstrapFileKernelAdaptor',
-                array($config['legacyApplicationBootstrapFile'])
-            );
-
-            $container
-                ->getDefinition('webfactory_legacy_integration.legacy_application')
-                ->addMethodCall('setLegacyKernel', array($wrap));
-        }
     }
 }

Resources/config/services.xml

@@ -5,10 +5,20 @@
            xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd">
     <services>
 
+        <service id="Webfactory\Bundle\LegacyIntegrationBundle\Integration\BootstrapFileKernelAdaptor">
+            <argument>%webfactory_legacy_integration.legacy_application_bootstrap_file%</argument>
+        </service>
+
+        <service id="webfactory_legacy_integration.legacy_kernel"
+                 alias="Webfactory\Bundle\LegacyIntegrationBundle\Integration\BootstrapFileKernelAdaptor" />
+
         <service
                 id="webfactory_legacy_integration.legacy_application"
                 class="Webfactory\Bundle\LegacyIntegrationBundle\Integration\LegacyApplication"
                 public="true">
+            <call method="setLegacyKernel">
+                <argument type="service" id="webfactory_legacy_integration.legacy_kernel" />
+            </call>
         </service>
 
         <service id="webfactory_legacy_integration.kernel_event_listener"