Skip to content

Commit dbf4152

Browse files
authored
Update test workflows and test matrix (#82)
This moves us closer to the current state of the PHP and Symfony ecosystem, preparing to upgrade to the upcoming Symfony 7.4/8.0 releases.
1 parent 2bc7977 commit dbf4152

7 files changed

Lines changed: 21 additions & 25 deletions

File tree

.github/workflows/dependencies.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ on:
77
pull_request:
88

99
env:
10-
PHP_VERSION: 8.1
10+
PHP_VERSION: 8.4
1111

1212
jobs:
1313
composer-require-checker:
@@ -34,4 +34,4 @@ jobs:
3434
composer install --no-interaction --no-scripts --no-progress --no-suggest
3535
composer show
3636
- name: ComposerRequireChecker
37-
uses: docker://ghcr.io/webfactory/composer-require-checker:4.8.0
37+
uses: docker://ghcr.io/webfactory/composer-require-checker:4.18.0

.github/workflows/fix-cs-php.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
ref: ${{ github.head_ref }}
2222

2323
- name: Run PHP-CS-Fixer
24-
uses: docker://ghcr.io/php-cs-fixer/php-cs-fixer:3.62.0-php8.3
24+
uses: docker://ghcr.io/php-cs-fixer/php-cs-fixer:3.89.2-php8.4
2525
with:
2626
args: "fix --show-progress=dots"
2727

.github/workflows/lock-symfony-version.sh

Lines changed: 0 additions & 3 deletions
This file was deleted.

.github/workflows/tests.yml

Lines changed: 15 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -8,35 +8,34 @@ on:
88

99
jobs:
1010
PHPUnit:
11-
1211
runs-on: ubuntu-22.04
1312
strategy:
1413
fail-fast: false
1514
matrix:
1615
include:
17-
- { php-version: 8.1, symfony-locked-version: none, orm-version: none, dependency-version: prefer-lowest }
18-
- { php-version: 8.1, symfony-locked-version: 6.4.*, orm-version: '^2.18', dependency-version: prefer-stable }
19-
- { php-version: 8.1, symfony-locked-version: 6.4.*, orm-version: none, dependency-version: prefer-stable }
20-
- { php-version: 8.2, symfony-locked-version: none, orm-version: '^2.18', dependency-version: prefer-stable }
21-
- { php-version: 8.3, symfony-locked-version: none, orm-version: none, dependency-version: prefer-stable }
22-
name: PHPUnit (PHP ${{matrix.php-version}}, Symfony Version Lock ${{ matrix.symfony-locked-version }}, ORM Version ${{matrix.orm-version }}, ${{ matrix.dependency-version }})
16+
- { php-version: 8.1, symfony-version: '', orm-version: '', dependency-version: prefer-lowest }
17+
- { php-version: 8.3, symfony-version: 6.4.*, orm-version: '^2.20', dependency-version: '' }
18+
- { php-version: 8.3, symfony-version: 6.4.*, orm-version: '^3.0', dependency-version: '' }
19+
- { php-version: 8.4, symfony-version: 7.*, orm-version: '^2.20', dependency-version: '' }
20+
- { php-version: 8.4, symfony-version: 7.*, orm-version: '^3.0', dependency-version: '' }
21+
name: PHPUnit (PHP ${{matrix.php-version}}, Symfony version constraint ${{ matrix.symfony-version || 'none' }}, Doctrine ORM version constraint ${{ matrix.orm-version || 'none' }}, ${{ matrix.dependency-version || 'prefer-stable' }})
2322
steps:
2423
- uses: actions/checkout@v4
2524
- uses: shivammathur/setup-php@v2
2625
with:
2726
php-version: ${{ matrix.php-version }}
2827
coverage: none
29-
tools: composer:v2
28+
tools: composer:v2, flex
3029
- uses: actions/cache@v4
3130
with:
3231
path: vendor
33-
key: composer-${{ runner.os }}-${{ matrix.php-version }}-${{ matrix.symfony-locked-version }}-${{ matrix.dependency-version }}-${{ hashFiles('composer.json') }}
32+
key: composer-${{ runner.os }}-${{ matrix.php-version }}-${{ matrix.symfony-version }}-${{ matrix.orm-version }}-${{ matrix.dependency-version }}-${{ hashFiles('composer.json') }}
3433
restore-keys: |
35-
composer-${{ runner.os }}-${{ matrix.php-version }}-${{ matrix.symfony-locked-version }}-${{ matrix.dependency-version }}-
36-
- run: VERSION=${{ matrix.symfony-locked-version }} .github/workflows/lock-symfony-version.sh
37-
if: matrix.symfony-locked-version != 'none'
38-
- run: composer require --no-update --no-interaction --no-scripts --no-progress --ansi doctrine/orm '${{ matrix.orm-version}}'
39-
if: matrix.orm-version != 'none'
40-
- run: composer update --${{ matrix.dependency-version }} --no-interaction --no-scripts --no-progress --ansi
34+
composer-${{ runner.os }}-${{ matrix.php-version }}-${{ matrix.symfony-version }}-${{ matrix.orm-version }}-${{ matrix.dependency-version }}-
35+
- run: composer require --no-update doctrine/orm '${{ matrix.orm-version }}' --no-interaction --no-scripts --no-progress --ansi
36+
if: matrix.orm-version != ''
37+
- run: composer update --no-interaction --no-scripts --no-progress --ansi --${{ matrix.dependency-version }}
38+
env:
39+
SYMFONY_REQUIRE: ${{ matrix.symfony-version }}
4140
- run: composer show
42-
- run: vendor/bin/phpunit
41+
- run: vendor/bin/phpunit --display-warnings --display-deprecations

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
},
2121

2222
"require": {
23-
"php": "8.1.*|8.2.*|8.3.*",
23+
"php": ">= 8.1",
2424
"doctrine/collections": "^1.0|^2.0",
2525
"doctrine/dbal": "^2.3|^3.0",
2626
"doctrine/event-manager": "^1.0|^2.0",

src/Doctrine/PersistentTranslatable.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,7 @@ private function isTranslationCached(string $locale): bool
241241
*/
242242
private function cacheTranslation(string $locale): void
243243
{
244-
/** @var $translationsInAllLanguages Selectable */
244+
/** @var Selectable $translationsInAllLanguages */
245245
$translationsInAllLanguages = $this->translationCollection->getValue($this->entity);
246246
$criteria = $this->createLocaleCriteria($locale);
247247
$translationsFilteredByLocale = $translationsInAllLanguages->matching($criteria);

src/Doctrine/TranslatableClassMetadata.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ final class TranslatableClassMetadata
7878
* their fields.
7979
*/
8080
private function __construct(
81-
private readonly string $class
81+
private readonly string $class,
8282
) {
8383
}
8484

0 commit comments

Comments
 (0)