Use static methods for PHPUnit data providers

Author: mpdude

tests/Functional/EmbeddedShortcodeHandlerTest.php

@@ -37,7 +37,7 @@ public function expand_shortcodes_registered_in_different_ways(string $shortcode
         self::assertSame('test foo=bar', $this->processShortcodes("[$shortcodeName foo=bar]"));
     }
 
-    public function provideShortcodeNames(): Generator
+    public static function provideShortcodeNames(): Generator
     {
         yield 'Inline shortcode defined in bundle config' => ['test-config-inline'];
         yield 'ESI-based shortcode defined in bundle config' => ['test-config-esi'];
@@ -58,7 +58,7 @@ public function processing_with_esi_fragments(string $shortcodeName): void
         self::assertStringContainsString('<esi:include ', $this->processShortcodes("[$shortcodeName foo=bar]", $request));
     }
 
-    public function provideEsiShortcodes(): Generator
+    public static function provideEsiShortcodes(): Generator
     {
         yield 'ESI-based shortcode defined in bundle configuration' => ['test-config-esi'];
         yield 'ESI-based shortcode defined in service configuration' => ['test-service-esi'];

tests/Functional/EndToEndTest.php

@@ -43,7 +43,7 @@ public function expand_shortcode_in__twig(string $shortcodeName): void
         self::assertSame('test foo=bar', $result);
     }
 
-    public function provideShortcodeNames(): Generator
+    public static function provideShortcodeNames(): Generator
     {
         yield 'Inline shortcode defined in bundle config' => ['test-config-inline'];
         yield 'ESI-based shortcode defined in bundle config' => ['test-config-esi'];
@@ -66,7 +66,7 @@ public function uses_esi_fragments(string $shortcodeName): void
         self::assertStringContainsString('<esi:include ', $result);
     }
 
-    public function provideEsiShortcodes(): Generator
+    public static function provideEsiShortcodes(): Generator
     {
         yield 'ESI-based shortcode defined in bundle configuration' => ['test-config-esi'];
         yield 'ESI-based shortcode defined in service configuration' => ['test-service-esi'];