Skip to content

fix test case in question-232#1212

Open
zhzhch335 wants to merge 1 commit into
webfansplz:mainfrom
zhzhch335:fix232test
Open

fix test case in question-232#1212
zhzhch335 wants to merge 1 commit into
webfansplz:mainfrom
zhzhch335:fix232test

Conversation

@zhzhch335
Copy link
Copy Markdown

In question 232,we need change add key modifiers made this will fire even if Alt or Shift is also pressed. But in the test case of question 232, if we passed the case

await buttons[0].trigger('click.alt')
expect(printLog).toMatchInlineSnapshot('"onClick1"')

printLog can't be empty, so that the case will always be passed until the next time to call console.log.
So even if the answer only writes alt key modifer like this:

<button @click.alt="onClick1">A</button>

it's still passed.

Futhermore, there isn't a case includes Alt and Shift are pressed at the same time, I added.

@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 9, 2022

Deploy Preview for vuejs-challenges ready!

Name Link
🔨 Latest commit ede82af
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-challenges/deploys/634273349599650008f962a1
😎 Deploy Preview https://deploy-preview-1212--vuejs-challenges.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@webfansplz webfansplz force-pushed the main branch 2 times, most recently from 4af2170 to 3715de0 Compare January 28, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant