Skip to content

Commit 4a90a0e

Browse files
committed
fix websocket issue in tests
1 parent fd8d352 commit 4a90a0e

3 files changed

Lines changed: 9 additions & 6 deletions

File tree

.github/workflows/node.js.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
strategy:
1313
fail-fast: false
1414
matrix:
15-
node: [20]
15+
node: [20, 24]
1616
mongodb-version: [8]
1717
python-version: [3.8]
1818
redis-version: [6]

test/common/storage/storageclasses/watchers_documents.spec.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ describe('watchers documents', function () {
2828

2929
before(function (done) {
3030
gmeConfig.authentication.enable = true;
31-
gmeConfig.socketIO.clientOptions.transports = ['websocket'];
31+
// gmeConfig.socketIO.clientOptions.transports = ['websocket'];
3232

3333
testFixture.clearDBAndGetGMEAuth(gmeConfig)
3434
.then(function (gmeAuth_) {
@@ -67,15 +67,16 @@ describe('watchers documents', function () {
6767
userTokens.user2 = res[1];
6868
userTokens.userNoAccess = res[2];
6969
userTokens.userRead = res[3];
70-
71-
server = WebGME.standaloneServer(gmeConfig);
7270
return Q.allDone([
73-
Q.ninvoke(server, 'start'),
7471
// Close connections since we don't need these anymore..
7572
gmeAuth.unload(),
7673
safeStorage.closeDatabase()
7774
]);
7875
})
76+
.then(function () {
77+
server = WebGME.standaloneServer(gmeConfig);
78+
return Q.ninvoke(server, 'start');
79+
})
7980
.nodeify(done);
8081
});
8182

test/plugin/coreplugins/OTAttributeEditing/OTAttributeEditing.spec.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,9 @@ describe('OTAttributeEditing Plugin', function () {
2424
safeStorage;
2525

2626
before(function (done) {
27-
gmeConfig.socketIO.clientOptions.transports = ['websocket'];
27+
// This fails with newer versions of node (22+),
28+
// just let socket-io pick the transport.
29+
// gmeConfig.socketIO.clientOptions.transports = ['websocket'];
2830
wr = new WorkerRequests(logger, gmeConfig);
2931

3032
testFixture.clearDBAndGetGMEAuth(gmeConfig)

0 commit comments

Comments
 (0)