Remove connect-multiparty librar - not used by engine or gui#345
Merged
Conversation
pmeijer
commented
May 5, 2026
| this.__app.use(cookieParser()); | ||
| this.__app.use(bodyParser.json(gmeConfig.server.bodyParser.json)); | ||
| this.__app.use(bodyParser.urlencoded({extended: true})); | ||
| this.__app.use((req, res, next) => { |
Contributor
Author
There was a problem hiding this comment.
body-parser removed initialization of request body, and secondly the multipart did add it.
Now we add it explicitly here as to not break any code.
kecso
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connect-multipartyhandles requests of typemultipart/form-datawhich is not used by either the server or the engine (not sure it ever was) - it could be used by an external router but in that case they should (at least first) try to handle it directly in the requests.