Skip to content

problem with fd installer #1065

@conceptoHH

Description

@conceptoHH

It seems there is an issue with the .ps1 version of the fd installer

Move-Item : No se encuentra la ruta de acceso 'C:\Users\PC\.local\tmp\fd.exe' porque no existe.
En C:\Users\PC\.local\tmp\fd.install.ps1: 175 Carácter: 5
+     & Move-Item "$EXENAME" "$VERNAME"
+     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (C:\Users\PC\.local\tmp\fd.exe:String) [Move-Item], ItemNotFoundExceptio
   n
    + FullyQualifiedErrorId : PathNotFound,Microsoft.PowerShell.Commands.MoveItemCommand

and executing the script in the tmp directory did bring the same error:

> cd .\.local\tmp\
> .\fd.install.ps1
Installing fd
Unpacking C:\Users\PC\Downloads\webi\fd-v10.4.2-x86_64-pc-windows-msvc.zip
Move-Item: C:\Users\PC\.local\tmp\fd.install.ps1:175
Line |
 175 |      & Move-Item "$EXENAME" "$VERNAME"
     |      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | Cannot find path 'C:\Users\PC\.local\tmp\fd.exe' because it does not exist.

It seems that the move-item command is trying to move fd.exe into the root of tmp but is failing because is searching directly in /tmp instead of the unpacked directory of $Env:WEBI_PKG_FILE.

It is a simple fix so i just modified the script in this way

    # Unpack archive
    # Windows BSD-tar handles zip. Imagine that.
    Write-Output "Unpacking $Env:USERPROFILE\Downloads\webi\$Env:WEBI_PKG_FILE"
    & tar xf "$Env:USERPROFILE\Downloads\webi\$Env:WEBI_PKG_FILE"
    # Move single binary into root of temporary folder
    & Move-Item "fd-v10.4.2-x86_64-pc-windows-msvc\$EXENAME" "$VERNAME"

After the fix:

> .\fd.install.ps1
Installing fd
Unpacking C:\Users\PC\Downloads\webi\fd-v10.4.2-x86_64-pc-windows-msvc.zip
New Name: fd-v10.4.2.exe
New Location: C:\Users\PC\.local\bin\fd-v10.4.2.exe
Copying into 'C:\Users\PC\.local\bin\fd.exe' from 'C:\Users\PC\.local\bin\fd-v10.4.2.exe'
> fd
fd-v10.4.2-x86_64-pc-windows-msvc\
fd-v10.4.2-x86_64-pc-windows-msvc\CHANGELOG.md
fd-v10.4.2-x86_64-pc-windows-msvc\LICENSE-APACHE
fd-v10.4.2-x86_64-pc-windows-msvc\LICENSE-MIT
fd-v10.4.2-x86_64-pc-windows-msvc\README.md

Also is my first open issue ever so i apologize if didn't follow any rules also i dont know if i need to create also a pull request let me know for any updates 👍🏽

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions