Skip to content

ref: delete unreachable upstream-fetcher modules#1076

Merged
coolaj86 merged 1 commit into
mainfrom
ref-cache-only-cleanup
May 14, 2026
Merged

ref: delete unreachable upstream-fetcher modules#1076
coolaj86 merged 1 commit into
mainfrom
ref-cache-only-cleanup

Conversation

@coolaj86

@coolaj86 coolaj86 commented May 7, 2026

Copy link
Copy Markdown
Member

Summary

Stacked on #1081. Pure deletion — zero file modifications, no behavior change. Once the supporting tools/tests stop referencing the obsolete fetcher modules (#1081), the modules themselves can be removed.

The Go cache daemon (webicached) is now the sole producer of release metadata; the Node process never makes an upstream request, so none of the deleted code is reachable from any live route.

What's deleted

  • ~93 per-package <pkg>/releases.js fetcher modules — the scrapers for GitHub, Brew, Gitea, git-tag, etc.
  • _common/{brew,fetcher,git-tag,gitea,github,github-source,githubish,githubish-source}.js — the shared HTTP/parsing helpers those fetchers built on.
  • _webi/normalize.js — the in-process normalization layer that fed transform-releases.js. Cache files are already normalized by webicached.
  • _example/releases.js — the template fetcher for new packages.

104 files changed, 4973 deletions(-)

Test plan

Stack

@coolaj86
coolaj86 force-pushed the ref-cache-only-cleanup branch 3 times, most recently from 04bcc30 to 90079cf Compare May 7, 2026 09:05
@coolaj86
coolaj86 force-pushed the ref-cache-only-readonly branch from e23efb8 to cb1e635 Compare May 7, 2026 09:42
@coolaj86
coolaj86 force-pushed the ref-cache-only-cleanup branch from 90079cf to 91b7770 Compare May 7, 2026 09:42
@coolaj86
coolaj86 force-pushed the ref-cache-only-readonly branch from cb1e635 to 38db91f Compare May 7, 2026 09:57
@coolaj86
coolaj86 force-pushed the ref-cache-only-cleanup branch 3 times, most recently from a6fad6e to d43dfcd Compare May 7, 2026 10:16
@coolaj86
coolaj86 force-pushed the ref-cache-only-readonly branch from 38db91f to cf465c2 Compare May 7, 2026 10:16
@coolaj86
coolaj86 force-pushed the ref-cache-only-cleanup branch 2 times, most recently from 9c17e98 to 79aeaec Compare May 7, 2026 10:22
@coolaj86
coolaj86 force-pushed the ref-cache-only-readonly branch from cf465c2 to f893288 Compare May 7, 2026 18:28
@coolaj86
coolaj86 force-pushed the ref-cache-only-cleanup branch from 79aeaec to 7ae6e0a Compare May 7, 2026 18:28
@coolaj86
coolaj86 force-pushed the ref-cache-only-readonly branch from f893288 to c2949c2 Compare May 7, 2026 18:33
@coolaj86
coolaj86 force-pushed the ref-cache-only-cleanup branch from 7ae6e0a to cf2d5d8 Compare May 7, 2026 18:34
@coolaj86
coolaj86 force-pushed the ref-cache-only-readonly branch from c2949c2 to e942312 Compare May 7, 2026 18:47
@coolaj86
coolaj86 force-pushed the ref-cache-only-cleanup branch from cf2d5d8 to e65a6a7 Compare May 7, 2026 18:47
@coolaj86
coolaj86 force-pushed the ref-cache-only-readonly branch from e942312 to 528ac12 Compare May 7, 2026 18:51
@coolaj86
coolaj86 force-pushed the ref-cache-only-cleanup branch from e65a6a7 to 05d148c Compare May 7, 2026 18:52
@coolaj86
coolaj86 force-pushed the ref-cache-only-readonly branch from 528ac12 to 91fc701 Compare May 7, 2026 18:58
@coolaj86
coolaj86 force-pushed the ref-cache-only-cleanup branch from 05d148c to 63e42e8 Compare May 7, 2026 18:59
@coolaj86
coolaj86 force-pushed the ref-cache-only-readonly branch from 91fc701 to f2ab4f6 Compare May 7, 2026 19:43
@coolaj86
coolaj86 force-pushed the ref-cache-only-cleanup branch from 63e42e8 to 9905149 Compare May 7, 2026 19:43
@coolaj86
coolaj86 force-pushed the ref-cache-only-readonly branch from f2ab4f6 to 89c5875 Compare May 7, 2026 19:50
@coolaj86
coolaj86 force-pushed the ref-cache-only-cleanup branch 2 times, most recently from e7de193 to 3d4c4b4 Compare May 7, 2026 19:51
@coolaj86
coolaj86 force-pushed the ref-cache-only-readonly branch 2 times, most recently from b5b2856 to 69a9d94 Compare May 7, 2026 20:52
@coolaj86
coolaj86 force-pushed the ref-cache-only-cleanup branch from 3d4c4b4 to 3077bf3 Compare May 7, 2026 20:52
@coolaj86
coolaj86 force-pushed the ref-cache-only-cleanup branch from 56c0766 to 47dfc42 Compare May 7, 2026 21:31
@coolaj86
coolaj86 force-pushed the ref-cache-only-readonly branch from 6ad85eb to 9117439 Compare May 7, 2026 21:40
@coolaj86
coolaj86 force-pushed the ref-cache-only-cleanup branch from 47dfc42 to dd4ad7e Compare May 7, 2026 21:41
@coolaj86
coolaj86 force-pushed the ref-cache-only-readonly branch from 9117439 to 9e2fbeb Compare May 8, 2026 02:10
@coolaj86
coolaj86 force-pushed the ref-cache-only-cleanup branch from dd4ad7e to 90f84bf Compare May 8, 2026 02:10
@coolaj86
coolaj86 force-pushed the ref-cache-only-readonly branch from 9e2fbeb to e4ccae9 Compare May 8, 2026 03:04
@coolaj86
coolaj86 force-pushed the ref-cache-only-cleanup branch from 90f84bf to 7272c29 Compare May 8, 2026 03:04
@coolaj86
coolaj86 force-pushed the ref-cache-only-readonly branch from e4ccae9 to 0c33383 Compare May 8, 2026 03:10
@coolaj86
coolaj86 force-pushed the ref-cache-only-cleanup branch 2 times, most recently from 480d4a6 to 63457ec Compare May 8, 2026 03:13
@coolaj86
coolaj86 force-pushed the ref-cache-only-readonly branch from 0c33383 to 9e2fbeb Compare May 8, 2026 03:14
@coolaj86
coolaj86 force-pushed the ref-cache-only-cleanup branch from 63457ec to 90f84bf Compare May 8, 2026 03:14
@coolaj86
coolaj86 force-pushed the ref-cache-only-readonly branch 3 times, most recently from b1d340e to 70067a6 Compare May 8, 2026 17:48
@coolaj86
coolaj86 force-pushed the ref-cache-only-cleanup branch from 90f84bf to 202b60e Compare May 8, 2026 18:15
Base automatically changed from ref-cache-only-readonly to main May 8, 2026 22:18
@coolaj86
coolaj86 force-pushed the ref-cache-only-cleanup branch from 202b60e to 5d80b5c Compare May 8, 2026 22:21
@coolaj86 coolaj86 changed the title ref: cache-only cleanup — drop dead fetchers, ship webicached deploy ref: remove dead upstream-fetcher code paths May 8, 2026
@coolaj86
coolaj86 force-pushed the ref-cache-only-cleanup branch from 5d80b5c to 95bff1f Compare May 8, 2026 22:27
Stacked on the modifications PR. Now that no live code path references
the per-package fetchers, the shared HTTP/parsing helpers, the
in-process normalizer, or the example template, delete them. Pure
deletion — no behavior change.

- ~93 per-package <pkg>/releases.js fetcher modules.
- _common/{brew,fetcher,git-tag,gitea,github,github-source,
  githubish,githubish-source}.js shared HTTP/parsing helpers.
- _webi/normalize.js in-process normalization layer (cache files
  arrive normalized from webicached).
- _example/releases.js fetcher template for new packages.

The Go cache daemon (webicached) is now the sole producer of release
metadata; the Node process never makes an upstream request.
@coolaj86
coolaj86 force-pushed the ref-cache-only-cleanup branch from 95bff1f to 9f28505 Compare May 8, 2026 22:35
@coolaj86 coolaj86 changed the title ref: remove dead upstream-fetcher code paths ref: delete unreachable upstream-fetcher modules May 8, 2026
@coolaj86
coolaj86 changed the base branch from main to ref-cache-only-mods May 8, 2026 23:07
Base automatically changed from ref-cache-only-mods to main May 14, 2026 21:02
pull Bot pushed a commit to pianomanx/webi-installers that referenced this pull request May 14, 2026
…e cache path

The Node server's read path now goes through ~/.cache/webi/legacy/ only
(see webinstall#1075). A handful of supporting tools and tests still carried
references to the obsolete upstream-fetcher modules and the old
year-month cache layout. Update them in place; the actual deletion of
the orphaned modules follows in webinstall#1076.

- _webi/classify-one.js — read from ~/.cache/webi/legacy/<pkg>.json
  instead of ../_cache/<yearMonth>/<pkg>.json.
- _webi/builds-cacher-test.js — drop the bc.freshenRandomPackage(...)
  call; the freshener was removed when fetching went away.
- _webi/builds.js — drop the //Releases: Releases stub comment.
- _webi/lint-builds.js — drop two now-unused require()s.
- _webi/test.js — adjust a single reference to the post-cleanup shape.
@coolaj86
coolaj86 merged commit 9f28505 into main May 14, 2026
3 checks passed
@coolaj86
coolaj86 deleted the ref-cache-only-cleanup branch May 14, 2026 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant