chore: remove dead createServerWebsockets + dbTable config#5404
Merged
Conversation
- Remove the unused `createServerWebsockets` export from `@webiny/api-websockets-server` (nothing consumed it; the server handler wires the transport/connection-manager directly). Drops its now-unused `@webiny/handler` dependency. - Remove the `dbTable` handler config option: since `DbFeature` became `DynamoDBCoreFeature` (which takes no table), nothing reads it. Dropped from the base config + the `-ddb` / `-ddb-os` variant Picks + the `-ddb-os` pass-through. No runtime behaviour change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
Author
|
/vitest |
|
Vitest tests have been initiated (for more information, click here). ✨
❌ Failed packagesDDB+OS
|
adrians5j
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Two small dead-code cleanups left over from the self-hosted server-flavour work, no runtime behaviour change:
createServerWebsocketsremoved from@webiny/api-websockets-server— it was exported but never consumed anywhere (the server API handler wires the transport, connection manager, and adapter directly). Its now-unused@webiny/handlerdependency was dropped too.dbTablehandler config option removed. OnceDbFeaturebecameDynamoDBCoreFeature(which takes no table name), nothing readdbTableanymore. Removed from the baseapi-event-handler-awsconfig and the-ddb/-ddb-osvariant configs.Changelog
Internal dead-code cleanup
Removed an unused WebSockets helper and an obsolete handler config option. No functional change.
Squash Merge Commit