refactor(build): remove --rebuild-dependents (redundant after dep-aware key)#5427
Closed
adrians5j wants to merge 1 commit into
Closed
refactor(build): remove --rebuild-dependents (redundant after dep-aware key)#5427adrians5j wants to merge 1 commit into
adrians5j wants to merge 1 commit into
Conversation
The dependency-aware effective key already marks every dependent of a changed package as a cache miss, so it rebuilds on a plain `yarn build`. The `--rebuild-dependents` flag was a manual, order-dependent approximation of the same thing (it anchored off transient cache misses and could miss its window). Remove it: the getBatches step 1.5 taint loop + the `rebuildDependents` option, and drop `--rebuild-dependents` from CI (regenerated push.yml/pullRequests.yml from their WAC sources). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
Author
|
Superseded: #5425 now gates the dependency-aware key behind |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #5425 — merge that first. Base is the dep-aware-key branch so this diff shows only the removal; retarget to
nextonce #5425 lands.Why
The dependency-aware effective key (#5425) marks every dependent of a changed package as a cache miss, so dependents rebuild on a plain
yarn build.--rebuild-dependentswas a manual, order-dependent approximation of the same propagation — it anchored off transient cache misses and silently did nothing if not run on the first build after a change. Now redundant.Changes
getBatches.ts: delete step 1.5 (the dependents taint loop) + therebuildDependentsoptionbuildPackages.ts: drop therebuildDependentsoption + pass-through--rebuild-dependents→ plainyarn build, edited the WAC sources (createInstallBuildSteps.ts,push.wac.ts,pullRequests.wac.ts) and regeneratedpush.yml/pullRequests.ymlVerified
yarn buildruns unchanged (flag no longer referenced)--rebuild-dependents; diffs are purely the flag removal🤖 Generated with Claude Code