perf(build): promote dependency-aware cache key to default, drop flag + --rebuild-dependents#5430
Draft
adrians5j wants to merge 1 commit into
Draft
perf(build): promote dependency-aware cache key to default, drop flag + --rebuild-dependents#5430adrians5j wants to merge 1 commit into
adrians5j wants to merge 1 commit into
Conversation
… + --rebuild-dependents Promotes the dependency-aware build key from opt-in to default and removes the now-redundant machinery. - remove the `WEBINY_EXPERIMENTAL_DEP_AWARE_CACHE` gate + `getOwnHashes`; `getBatches` always uses the dependency-aware key - remove `--rebuild-dependents`: getBatches step 1.5, the `rebuildDependents` option, and the CI flag (WAC sources + regenerated push.yml/pullRequests.yml) A plain `yarn build` now rebuilds any changed package plus all its dependents (workspace or resolved third-party) on its own. NOTE: first build after this merges is a one-time full rebuild everywhere — stored meta holds own-source hashes (flag was off) and now mismatches the dependency-aware keys. The nightly global-cache rebuild absorbs it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft — merge only once the experimental flag has been validated. Pre-staged so it's ready to go the moment testing passes.
Promotes the dependency-aware build key (#5425) from opt-in to default and removes the now-redundant machinery.
Changes
WEBINY_EXPERIMENTAL_DEP_AWARE_CACHEgate +getOwnHashes;getBatchesalways uses the dependency-aware key.--rebuild-dependents:getBatchesstep 1.5, therebuildDependentsoption, and the CI flag (edited WAC sources, regeneratedpush.yml/pullRequests.yml; yml diffs are pure flag removal).Result: a plain
yarn buildrebuilds any changed package + all its dependents (workspace or resolved third-party) on its own.Stored
meta.jsonholds own-source hashes (flag was off) and now mismatches the dependency-aware keys → every package is a miss on the first build → one full rebuild everywhere. The nightly global-cache rebuild absorbs it; heads-up for the team so a slow first CI build isn't alarming. Steady-state after is normal.Before merging — validation checklist (flag on, on
next)WEBINY_EXPERIMENTAL_DEP_AWARE_CACHE=1 yarn buildacross normal dev flowswebiny watch→ build → dist correct🤖 Generated with Claude Code