Skip to content

Commit fc771a7

Browse files
haggaiewebispy
authored andcommitted
Use a git-format-patch instead of git-show for review
DPDK's checkpatches.sh seem to work better with files generated by format-patch compared to piping git show into stdin. Signed-off-by: Haggai Eran <haggaie@nvidia.com>
1 parent 9582824 commit fc771a7

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

review.sh

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@
44
#set -x
55

66
# Generate email style commit message
7-
PATCHMAIL=$(git show --format=email $1 | checkpatch.pl --no-tree -)
7+
PATCH_FILE=$(git format-patch $1 -1)
8+
PATCHMAIL=$(checkpatch.pl --no-tree $PATCH_FILE)
89

910
# Internal state variables
1011
RESULT=0
@@ -101,4 +102,4 @@ else
101102
echo -e "\e[1;31m>> Failure\e[0m"
102103
fi
103104

104-
exit $RESULT
105+
exit $RESULT

0 commit comments

Comments
 (0)