Fix types for restricted mail/announcements#5954
Open
ch0rizo wants to merge 1 commit into
Open
Conversation
ch0rizo
added
types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix types in restricted mail / announcements
Testing
Cause: FormValues typed the autocomplete fields as raw entities, but the form
holds the post-transformAutocompletes shape (SearchResult, with .value). The
same type was re-imported by createAnnouncement for its body - but the API
body is just IDs.
Fix:
meetingInvitationStatus.
body.
Errors fixed
initialValues (3× TS2322): SearchResult[] vs declared entity arrays - lines
90, 98, 106.
.value access in onSubmit (5× TS2339, 1× TS2551): declared types have no
.value - lines 124, 125, 126, 127, 128, 129.