chore(deps): Upgrade to PHPStan 2 (#305)

Author: theofidry

composer.json

@@ -33,13 +33,13 @@
         "ergebnis/composer-normalize": "^2.45",
         "fidry/makefile": "^1.1.1",
         "infection/infection": "^0.29.14",
-        "jangregor/phpstan-prophecy": "^1.0.2",
+        "jangregor/phpstan-prophecy": "^2.1.1",
         "phpspec/prophecy-phpunit": "^2.3",
-        "phpstan/extension-installer": "^1.4.3",
-        "phpstan/phpstan": "^1.12.23",
-        "phpstan/phpstan-phpunit": "^1.4.2",
-        "phpstan/phpstan-symfony": "^1.4.14",
-        "phpstan/phpstan-webmozart-assert": "^1.2.11",
+        "phpstan/extension-installer": "^1.1",
+        "phpstan/phpstan": "^2.1.10",
+        "phpstan/phpstan-phpunit": "^2.0.4",
+        "phpstan/phpstan-symfony": "^2.0.3",
+        "phpstan/phpstan-webmozart-assert": "^2.0",
         "phpunit/phpunit": "^10.5.45 || ^11.0",
         "symfony/framework-bundle": "^6.4.19 || ^7.2.4",
         "webmozarts/strict-phpunit": "^7.13.1"

phpstan-src.neon.dist

@@ -10,3 +10,12 @@ parameters:
 
         - path: src/Input/ChildCommandFactory.php
           message: '#Parameter \#1 \$callback of function array_map expects#'
+
+        - path: src/Configuration.php
+          identifier: staticMethod.alreadyNarrowedType
+
+        - path: src/Input/RawInput.php
+          identifier: return.type
+
+        - path: src/Parallelization.php
+          identifier: trait.unused

phpstan-tests.neon.dist

@@ -6,12 +6,8 @@ parameters:
     excludePaths:
         - tests/Integration/App/var
         - tests/Input/FakeInput.php
-        - tests/Input/FakeInput74.php
-        - tests/Input/FakeInput81.php
         - tests/Input/FakeSymfony6Input.php
         - tests/Process/DummyProcess.php
-        - tests/Process/DummyProcess74.php
-        - tests/Process/DummyProcess81.php
     ignoreErrors:
         - path: tests/Integration/TestLogger.php
           message: '#TestLogger::\$outputHandler#'
@@ -39,5 +35,7 @@ parameters:
         - path: tests/Input/RawInputTest.php
           message: '#Webmozarts\\Console\\Parallelization\\Input\\FakeInput#'
 
+        - path: tests/LazyRewindableIteratorTest.php
+          identifier: staticMethod.alreadyNarrowedType
         - path: tests/LazyRewindableIteratorTest.php
           identifier: staticMethod.impossibleType

src/ChunkedItemsIterator.php

@@ -70,6 +70,7 @@ public function __construct(
             $this->numberOfItems = null;
         }
 
+        /** @phpstan-ignore assign.propertyType */
         $this->itemsChunks = chunk($this->items, $batchSize);
     }
 
@@ -116,6 +117,7 @@ public static function fromItemOrCallable(?string $item, callable $fetchItems, i
      */
     public function getItems(): array|LazyRewindableIterator
     {
+        // @phpstan-ignore-next-line return.type
         return $this->items;
     }
 
@@ -189,7 +191,6 @@ private static function normalizeItem(mixed $item, mixed $index): string
             ),
         );
         Assert::false(
-            // TODO: legit bug
             '' !== $item && str_contains($item, PHP_EOL),
             sprintf(
                 'An item cannot contain a line return. Got one for "%s" for the item "%s".',

src/Input/InputOptionsSerializer.php

@@ -70,6 +70,7 @@ private static function serializeOption(
         string $name,
         array|bool|float|int|string|null $value,
     ): array {
+        // @phpstan-ignore-next-line return.type argument.type
         return match (true) {
             $option->isNegatable() => [sprintf('--%s%s', $value ? '' : 'no-', $name)],
             !$option->acceptValue() => [sprintf('--%s', $name)],

src/ParallelExecutorFactory.php

@@ -17,6 +17,7 @@
 use Symfony\Component\Console\Input\InputDefinition;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
+use Webmozart\Assert\Assert;
 use Webmozarts\Console\Parallelization\ErrorHandler\ErrorHandler;
 use Webmozarts\Console\Parallelization\Input\ChildCommandFactory;
 use Webmozarts\Console\Parallelization\Process\PhpExecutableFinder;
@@ -336,6 +337,7 @@ private static function getNoopClosure(): Closure
         }
         // @codeCoverageIgnoreEnd
 
+        /** @phpstan-ignore return.type */
         return $noop;
     }
 
@@ -344,6 +346,9 @@ private static function getScriptPath(): string
         $pwd = $_SERVER['PWD'] ?? getcwd();
         $scriptName = $_SERVER['SCRIPT_NAME'];
 
+        Assert::string($pwd);
+        Assert::string($scriptName);
+
         return (str_starts_with($scriptName, $pwd)
                 || str_starts_with($scriptName, DIRECTORY_SEPARATOR)
         )

src/Process/PhpExecutableFinder.php

@@ -49,6 +49,7 @@ public static function find(): array
             'Could not find the PHP executable.',
         );
 
+        /** @phpstan-ignore return.type */
         return array_values([
             $phpExecutable,
             ...$finder->findArguments(),

tests/ChunkedItemsIteratorTest.php

@@ -131,6 +131,7 @@ static function () use (&$itemsFetched) {
         self::assertFalse($itemsFetched);
 
         self::assertNull($iterator->getNumberOfItems());
+        // @phpstan-ignore staticMethod.alreadyNarrowedType
         self::assertFalse($itemsFetched);
 
         self::assertSame(['item1', 'item2'], toArrayWithKeys($iterator->getItems()));