Codec-Compare version 0.1.9 (#2)

Author: y-guyon

.gitignore

@@ -0,0 +1,2 @@
+node_modules
+package-lock.json

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## v0.1.9
+
+- Use bits-per-pixel instead of bytes-per-pixel for the "bpp" metric.
+
 ## v0.1.8
 
 - Add matcher warning display capability.

package.json

@@ -1,6 +1,6 @@
 {
   "name": "codec_compare",
-  "version": "0.1.8",
+  "version": "0.1.9",
   "description": "Codec performance comparison tool",
   "publisher": "Google LLC",
   "author": "Yannis Guyon",

src/codec_compare.ts

@@ -143,7 +143,7 @@ export class CodecCompare extends LitElement {
           </p>
 
           <p id="credits">
-            Codec Compare beta version 0.1.8<br>
+            Codec Compare beta version 0.1.9<br>
             <a href="https://github.com/webmproject/codec-compare">
               Sources on GitHub
             </a>

src/entry_loader.ts

@@ -215,11 +215,11 @@ function jsonToBatch(
       batch.fields.push(field);
       uniqueValuesSets.push(new Set<string>());
       for (const row of batch.rows) {
-        const value = (row[encodedSizeFieldIndex] as number) /
+        const bpp = (row[encodedSizeFieldIndex] as number) * 8 /
             ((row[widthFieldIndex] as number) *
              (row[heightFieldIndex] as number));
-        row.push(value);
-        field.addValue(String(value), uniqueValuesSets[fieldIndex]);
+        row.push(bpp);
+        field.addValue(String(bpp), uniqueValuesSets[fieldIndex]);
       }
       processField(field, fieldIndex);
     }

src/entry_loader_test.ts

@@ -76,6 +76,28 @@ describe('loadBatchJson', () => {
       expect(field.isInteger).toBeFalse();
       expect(field.uniqueValuesArray).not.toHaveSize(0);
       expect(field.rangeStart).toBeLessThan(field.rangeEnd);
+
+      // Make sure the computation is correct.
+      const encodedSizeFieldIndex =
+          batch.fields.findIndex((field) => field.id === FieldId.ENCODED_SIZE);
+      const widthFieldIndex =
+          batch.fields.findIndex((field) => field.id === FieldId.WIDTH);
+      const heightFieldIndex =
+          batch.fields.findIndex((field) => field.id === FieldId.HEIGHT);
+      expect(encodedSizeFieldIndex).not.toBe(-1);
+      expect(widthFieldIndex).not.toBe(-1);
+      expect(heightFieldIndex).not.toBe(-1);
+      if (encodedSizeFieldIndex !== -1 && widthFieldIndex !== -1 &&
+          heightFieldIndex !== -1) {
+        for (const row of batch.rows) {
+          expect(row[bppFieldIndex])
+              .toBeCloseTo(
+                  (row[encodedSizeFieldIndex] as number) * 8 /
+                      ((row[widthFieldIndex] as number) *
+                       (row[heightFieldIndex] as number)),
+                  0.001);
+        }
+      }
     }
   });