chore: CVE-2023-5217

Author: gabrielfalcao

examples/set_maps.c

@@ -64,7 +64,7 @@ static void set_roi_map(const vpx_codec_enc_cfg_t *cfg,
                         vpx_codec_ctx_t *codec) {
   unsigned int i;
   vpx_roi_map_t roi;
-  memset(&roi, 0, sizeof(roi));
+  bzero(&roi, sizeof(roi));
 
   roi.rows = (cfg->g_h + 15) / 16;
   roi.cols = (cfg->g_w + 15) / 16;
@@ -166,7 +166,7 @@ int main(int argc, char **argv) {
   exec_name = argv[0];
   if (argc != 6) die("Invalid number of arguments");
 
-  memset(&info, 0, sizeof(info));
+  bzero(&info, sizeof(info));
 
   encoder = get_vpx_encoder_by_name(argv[1]);
   if (encoder == NULL) {

examples/svc_encodeframe.c

@@ -84,7 +84,7 @@ static SvcInternal_t *get_svc_internal(SvcContext *svc_ctx) {
   if (svc_ctx->internal == NULL) {
     SvcInternal_t *const si = (SvcInternal_t *)malloc(sizeof(*si));
     if (si != NULL) {
-      memset(si, 0, sizeof(*si));
+      bzero(si, sizeof(*si));
     }
     svc_ctx->internal = si;
   }

examples/vp9_spatial_svc_encoder.c

@@ -900,11 +900,11 @@ int main(int argc, const char **argv) {
   int mismatch_seen = 0;
   vpx_codec_ctx_t decoder;
 #endif
-  memset(&svc_ctx, 0, sizeof(svc_ctx));
-  memset(&app_input, 0, sizeof(AppInput));
-  memset(&info, 0, sizeof(VpxVideoInfo));
-  memset(&layer_id, 0, sizeof(vpx_svc_layer_id_t));
-  memset(&rc, 0, sizeof(struct RateControlStats));
+  bzero(&svc_ctx, sizeof(svc_ctx));
+  bzero(&app_input, sizeof(AppInput));
+  bzero(&info, sizeof(VpxVideoInfo));
+  bzero(&layer_id, sizeof(vpx_svc_layer_id_t));
+  bzero(&rc, sizeof(struct RateControlStats));
   exec_name = argv[0];
 
   /* Setup default input stream settings */

examples/vpx_temporal_svc_encoder.c

@@ -30,7 +30,7 @@
 
 #define ROI_MAP 0
 
-#define zero(Dest) memset(&(Dest), 0, sizeof(Dest))
+#define zero(Dest) bzero(&(Dest), sizeof(Dest))
 
 static const char *exec_name;
 
@@ -671,8 +671,8 @@ int main(int argc, char **argv) {
   int *prev_mask_map;
 #endif
   zero(rc.layer_target_bitrate);
-  memset(&layer_id, 0, sizeof(vpx_svc_layer_id_t));
-  memset(&input_ctx, 0, sizeof(input_ctx));
+  bzero(&layer_id, sizeof(vpx_svc_layer_id_t));
+  bzero(&input_ctx, sizeof(input_ctx));
   /* Setup default input stream settings */
   input_ctx.framerate.numerator = 30;
   input_ctx.framerate.denominator = 1;
@@ -898,7 +898,7 @@ int main(int argc, char **argv) {
 #endif
   } else if (strncmp(encoder->name, "vp9", 3) == 0) {
     vpx_svc_extra_cfg_t svc_params;
-    memset(&svc_params, 0, sizeof(svc_params));
+    bzero(&svc_params, sizeof(svc_params));
     vpx_codec_control(&codec, VP9E_SET_POSTENCODE_DROP, 0);
     vpx_codec_control(&codec, VP9E_SET_DISABLE_OVERSHOOT_MAXQ_CBR, 0);
     vpx_codec_control(&codec, VP8E_SET_CPUUSED, speed);

md5_utils.c

@@ -112,14 +112,14 @@ void MD5Final(md5byte digest[16], struct MD5Context *ctx) {
   count = 56 - 1 - count;
 
   if (count < 0) { /* Padding forces an extra block */
-    memset(p, 0, count + 8);
+    bzero(p, count + 8);
     byteSwap(ctx->in, 16);
     MD5Transform(ctx->buf, ctx->in);
     p = (md5byte *)ctx->in;
     count = 56;
   }
 
-  memset(p, 0, count);
+  bzero(p, count);
   byteSwap(ctx->in, 14);
 
   /* Append length in bits and transform */
@@ -129,7 +129,7 @@ void MD5Final(md5byte digest[16], struct MD5Context *ctx) {
 
   byteSwap(ctx->buf, 4);
   memcpy(digest, ctx->buf, 16);
-  memset(ctx, 0, sizeof(*ctx)); /* In case it's sensitive */
+  bzero(ctx, sizeof(*ctx)); /* In case it's sensitive */
 }
 
 #ifndef ASM_MD5

test/add_noise_test.cc

@@ -83,7 +83,7 @@ TEST_P(AddNoiseTest, CheckNoiseAdded) {
   }
 
   // Initialize pixels in the image to 0 and check for roll under.
-  memset(s, 0, image_size);
+  bzero(s, image_size);
 
   ASM_REGISTER_STATE_CHECK(
       GET_PARAM(1)(s, noise, clamp, clamp, width, height, width));

test/consistency_test.cc

@@ -51,7 +51,7 @@ class ConsistencyTestBase : public ::testing::Test {
     ssim_array_ = new Ssimv[kDataBufferSize / 16];
   }
 
-  static void ClearSsim() { memset(ssim_array_, 0, kDataBufferSize / 16); }
+  static void ClearSsim() { bzero(ssim_array_, kDataBufferSize / 16); }
   static void TearDownTestSuite() {
     vpx_free(source_data_[0]);
     source_data_[0] = nullptr;

test/dct16x16_test.cc

@@ -459,11 +459,11 @@ class Trans16x16TestBase {
       fwd_txfm_ref(input_extreme_block, output_ref_block, pitch_, tx_type_);
 
       // clear reconstructed pixel buffers
-      memset(dst, 0, kNumCoeffs * sizeof(uint8_t));
-      memset(ref, 0, kNumCoeffs * sizeof(uint8_t));
+      bzero(dst, kNumCoeffs * sizeof(uint8_t));
+      bzero(ref, kNumCoeffs * sizeof(uint8_t));
 #if CONFIG_VP9_HIGHBITDEPTH
-      memset(dst16, 0, kNumCoeffs * sizeof(uint16_t));
-      memset(ref16, 0, kNumCoeffs * sizeof(uint16_t));
+      bzero(dst16, kNumCoeffs * sizeof(uint16_t));
+      bzero(ref16, kNumCoeffs * sizeof(uint16_t));
 #endif
 
       // quantization with maximum allowed step sizes

test/decode_test_driver.h

@@ -40,12 +40,12 @@ class Decoder {
  public:
   explicit Decoder(vpx_codec_dec_cfg_t cfg)
       : cfg_(cfg), flags_(0), init_done_(false) {
-    memset(&decoder_, 0, sizeof(decoder_));
+    bzero(&decoder_, sizeof(decoder_));
   }
 
   Decoder(vpx_codec_dec_cfg_t cfg, const vpx_codec_flags_t flag)
       : cfg_(cfg), flags_(flag), init_done_(false) {
-    memset(&decoder_, 0, sizeof(decoder_));
+    bzero(&decoder_, sizeof(decoder_));
   }
 
   virtual ~Decoder() { vpx_codec_destroy(&decoder_); }

test/encode_api_test.cc

@@ -141,7 +141,7 @@ TEST(EncodeAPI, MultiResEncode) {
     vpx_codec_enc_cfg_t cfg[2];
     vpx_rational_t dsf[2] = { { 2, 1 }, { 2, 1 } };
 
-    memset(enc, 0, sizeof(enc));
+    bzero(enc, sizeof(enc));
 
     for (int i = 0; i < 2; i++) {
       vpx_codec_enc_config_default(iface, &cfg[i], 0);