Fix PHPStan

Author: spawnia

src/Type/Definition/CustomScalarType.php

@@ -101,19 +101,19 @@ public function assertValid(): void
             throw new InvariantViolation("{$this->name} must provide \"parseValue\" and \"parseLiteral\" functions, \"serialize\" function, or both.");
         }
 
-        // @phpstan-ignore-next-line not necessary according to types, but can happen during runtime
+        // @phpstan-ignore-next-line unnecessary according to types, but can happen during runtime
         if ($hasSerialize && ! is_callable($serialize)) {
             $notCallable = Utils::printSafe($serialize);
             throw new InvariantViolation("{$this->name} must provide \"serialize\" as a callable if given, but got: {$notCallable}.");
         }
 
-        // @phpstan-ignore-next-line not necessary according to types, but can happen during runtime
+        // @phpstan-ignore-next-line unnecessary according to types, but can happen during runtime
         if ($hasParseValue && ! is_callable($parseValue)) {
             $notCallable = Utils::printSafe($parseValue);
             throw new InvariantViolation("{$this->name} must provide \"parseValue\" as a callable if given, but got: {$notCallable}.");
         }
 
-        // @phpstan-ignore-next-line not necessary according to types, but can happen during runtime
+        // @phpstan-ignore-next-line unnecessary according to types, but can happen during runtime
         if ($hasParseLiteral && ! is_callable($parseLiteral)) {
             $notCallable = Utils::printSafe($parseLiteral);
             throw new InvariantViolation("{$this->name} must provide \"parseLiteral\" as a callable if given, but got: {$notCallable}.");

src/Type/Definition/EnumType.php

@@ -222,7 +222,7 @@ public function assertValid(): void
     {
         Utils::assertValidName($this->name);
 
-        $values = $this->config['values'] ?? null;
+        $values = $this->config['values'] ?? null; // @phpstan-ignore nullCoalesce.initializedProperty (unnecessary according to types, but can happen during runtime)
         if (! is_iterable($values) && ! is_callable($values)) {
             $notIterable = Utils::printSafe($values);
             throw new InvariantViolation("{$this->name} values must be an iterable or callable, got: {$notIterable}");

src/Type/Definition/FieldDefinition.php

@@ -238,7 +238,7 @@ public function assertValid(Type $parentType): void
             throw new InvariantViolation("{$parentType->name}.{$this->name} field type must be Output Type but got: {$safeType}.");
         }
 
-        // @phpstan-ignore-next-line not necessary according to types, but can happen during runtime
+        // @phpstan-ignore-next-line unnecessary according to types, but can happen during runtime
         if ($this->resolveFn !== null && ! is_callable($this->resolveFn)) {
             $safeResolveFn = Utils::printSafe($this->resolveFn);
             throw new InvariantViolation("{$parentType->name}.{$this->name} field resolver must be a function if provided, but got: {$safeResolveFn}.");

src/Type/Definition/InputObjectType.php

@@ -181,7 +181,7 @@ public function assertValid(): void
     {
         Utils::assertValidName($this->name);
 
-        $fields = $this->config['fields'] ?? null;
+        $fields = $this->config['fields'] ?? null; // @phpstan-ignore nullCoalesce.initializedProperty (unnecessary according to types, but can happen during runtime)
         if (is_callable($fields)) {
             $fields = $fields();
         }

src/Type/Definition/InterfaceType.php

@@ -85,7 +85,7 @@ public function assertValid(): void
         Utils::assertValidName($this->name);
 
         $resolveType = $this->config['resolveType'] ?? null;
-        // @phpstan-ignore-next-line not necessary according to types, but can happen during runtime
+        // @phpstan-ignore-next-line unnecessary according to types, but can happen during runtime
         if ($resolveType !== null && ! is_callable($resolveType)) {
             $notCallable = Utils::printSafe($resolveType);
             throw new InvariantViolation("{$this->name} must provide \"resolveType\" as null or a callable, but got: {$notCallable}.");

src/Type/Definition/ObjectType.php

@@ -154,7 +154,7 @@ public function assertValid(): void
         Utils::assertValidName($this->name);
 
         $isTypeOf = $this->config['isTypeOf'] ?? null;
-        // @phpstan-ignore-next-line not necessary according to types, but can happen during runtime
+        // @phpstan-ignore-next-line unnecessary according to types, but can happen during runtime
         if (isset($isTypeOf) && ! is_callable($isTypeOf)) {
             $notCallable = Utils::printSafe($isTypeOf);
             throw new InvariantViolation("{$this->name} must provide \"isTypeOf\" as null or a callable, but got: {$notCallable}.");

src/Type/Definition/UnionType.php

@@ -89,7 +89,7 @@ public function getTypes(): array
         if (! isset($this->types)) {
             $this->types = [];
 
-            $types = $this->config['types'] ?? null;
+            $types = $this->config['types'] ?? null; // @phpstan-ignore nullCoalesce.initializedProperty (unnecessary according to types, but can happen during runtime)
             if (is_callable($types)) {
                 $types = $types();
             }
@@ -120,7 +120,7 @@ public function assertValid(): void
         Utils::assertValidName($this->name);
 
         $resolveType = $this->config['resolveType'] ?? null;
-        // @phpstan-ignore-next-line not necessary according to types, but can happen during runtime
+        // @phpstan-ignore-next-line unnecessary according to types, but can happen during runtime
         if (isset($resolveType) && ! is_callable($resolveType)) {
             $notCallable = Utils::printSafe($resolveType);
             throw new InvariantViolation("{$this->name} must provide \"resolveType\" as null or a callable, but got: {$notCallable}.");

src/Utils/Utils.php

@@ -116,7 +116,10 @@ public static function chr(int $ord, string $encoding = 'UTF-8'): string
             return pack('N', $ord);
         }
 
-        return mb_convert_encoding(self::chr($ord, 'UCS-4BE'), $encoding, 'UCS-4BE');
+        $converted = mb_convert_encoding(self::chr($ord, 'UCS-4BE'), $encoding, 'UCS-4BE');
+        assert(is_string($converted), 'format string is statically known to be correct');
+
+        return $converted;
     }
 
     /** UTF-8 compatible ord(). */
@@ -128,10 +131,13 @@ public static function ord(string $char, string $encoding = 'UTF-8'): int
 
         if ($encoding !== 'UCS-4BE') {
             $char = mb_convert_encoding($char, 'UCS-4BE', $encoding);
+            assert(is_string($char), 'format string is statically known to be correct');
         }
 
-        // @phpstan-ignore-next-line format string is statically known to be correct
-        return unpack('N', $char)[1];
+        $unpacked = unpack('N', $char);
+        assert(is_array($unpacked), 'format string is statically known to be correct');
+
+        return $unpacked[1];
     }
 
     /** Returns UTF-8 char code at given $positing of the $string. */

tests/Language/PrinterTest.php

@@ -44,7 +44,7 @@ public function testPrintsMinimalAst(): void
     /** @see it('produces helpful error messages', () => { */
     public function testProducesHelpfulErrorMessages(): void
     {
-        self::markTestSkipped('Not necessary because our class based AST makes it impossible to pass bad data.');
+        self::markTestSkipped('Unnecessary because our class based AST makes it impossible to pass bad data.');
     }
 
     /** @see it('correctly prints non-query operations without name', () => { */

tests/Utils/CoerceInputValueTest.php

@@ -479,7 +479,7 @@ public function testReturnsNestedNullForNestedNullValues(): void
      * @see it('throw error without path', () => {
      * @see it('throw error with path', () => {
      *
-     * Not necessary because we do not implement the callback variant coerceInputValue.
+     * Unnecessary because we do not implement the callback variant coerceInputValue.
      */
 
     /**