Consistently assign configuration values to properties in InputObjectType

Author: spawnia

src/Type/Definition/InputObjectType.php

@@ -14,11 +14,12 @@
  * @phpstan-type EagerFieldConfig InputObjectField|(Type&InputType)|UnnamedInputObjectFieldConfig
  * @phpstan-type LazyFieldConfig callable(): EagerFieldConfig
  * @phpstan-type FieldConfig EagerFieldConfig|LazyFieldConfig
+ * @phpstan-type ParseValueFn callable(array<string, mixed>): mixed
  * @phpstan-type InputObjectConfig array{
  *   name?: string|null,
  *   description?: string|null,
  *   fields: iterable<FieldConfig>|callable(): iterable<FieldConfig>,
- *   parseValue?: callable(array<string, mixed>): mixed,
+ *   parseValue?: ParseValueFn|null,
  *   astNode?: InputObjectTypeDefinitionNode|null,
  *   extensionASTNodes?: array<InputObjectTypeExtensionNode>|null
  * }
@@ -27,6 +28,16 @@ class InputObjectType extends Type implements InputType, NullableType, NamedType
 {
     use NamedTypeImplementation;
 
+    /**
+     * Lazily initialized.
+     *
+     * @var array<string, InputObjectField>
+     */
+    private array $fields;
+
+    /** @var ParseValueFn|null */
+    private $parseValue;
+
     public ?InputObjectTypeDefinitionNode $astNode;
 
     /** @var array<InputObjectTypeExtensionNode> */
@@ -35,13 +46,6 @@ class InputObjectType extends Type implements InputType, NullableType, NamedType
     /** @phpstan-var InputObjectConfig */
     public array $config;
 
-    /**
-     * Lazily initialized.
-     *
-     * @var array<string, InputObjectField>
-     */
-    private array $fields;
-
     /**
      * @throws InvariantViolation
      *
@@ -53,6 +57,8 @@ public function __construct(array $config)
     {
         $this->name = $config['name'] ?? $this->inferName();
         $this->description = $config['description'] ?? null;
+        // $this->fields is initialized lazily
+        $this->parseValue = $config['parseValue'] ?? null;
         $this->astNode = $config['astNode'] ?? null;
         $this->extensionASTNodes = $config['extensionASTNodes'] ?? [];
 
@@ -155,23 +161,23 @@ protected function initializeField($nameOrIndex, $field): void
     /**
      * Parses an externally provided value (query variable) to use as an input.
      *
-     * Should throw an exception with a client friendly message on invalid values, @see ClientAware.
+     * Should throw an exception with a client-friendly message on invalid values, @see ClientAware.
      *
      * @param array<string, mixed> $value
      *
      * @return mixed
      */
     public function parseValue(array $value)
     {
-        if (isset($this->config['parseValue'])) {
-            return $this->config['parseValue']($value);
+        if (isset($this->parseValue)) {
+            return ($this->parseValue)($value);
         }
 
         return $value;
     }
 
     /**
-     * Validates type config and throws if one of type options is invalid.
+     * Validates type config and throws if one of the type options is invalid.
      * Note: this method is shallow, it won't validate object fields and their arguments.
      *
      * @throws Error

src/Type/Definition/LeafType.php

@@ -31,7 +31,7 @@ public function serialize($value);
     /**
      * Parses an externally provided value (query variable) to use as an input.
      *
-     * Should throw an exception with a client friendly message on invalid values, @see ClientAware.
+     * Should throw an exception with a client-friendly message on invalid values, @see ClientAware.
      *
      * @param mixed $value
      *
@@ -44,7 +44,7 @@ public function parseValue($value);
     /**
      * Parses an externally provided literal value (hardcoded in GraphQL query) to use as an input.
      *
-     * Should throw an exception with a client friendly message on invalid value nodes, @see ClientAware.
+     * Should throw an exception with a client-friendly message on invalid value nodes, @see ClientAware.
      *
      * @param ValueNode&Node $valueNode
      * @param array<string, mixed>|null $variables

src/Type/Definition/ObjectType.php

@@ -143,7 +143,7 @@ public function isTypeOf($objectValue, $context, ResolveInfo $info)
     }
 
     /**
-     * Validates type config and throws if one of type options is invalid.
+     * Validates type config and throws if one of the type options is invalid.
      * Note: this method is shallow, it won't validate object fields and their arguments.
      *
      * @throws Error