Skip to content

Commit 2b9f2ec

Browse files
authored
Make type hint for InputValueDefinitionNode#defaultValue nullable (#654)
1 parent 3c37c51 commit 2b9f2ec

3 files changed

Lines changed: 2 additions & 7 deletions

File tree

phpstan-baseline.neon

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -810,11 +810,6 @@ parameters:
810810
count: 1
811811
path: src/Utils/ASTDefinitionBuilder.php
812812

813-
-
814-
message: "#^Only booleans are allowed in an if condition, GraphQL\\\\Language\\\\AST\\\\BooleanValueNode\\|GraphQL\\\\Language\\\\AST\\\\EnumValueNode\\|GraphQL\\\\Language\\\\AST\\\\FloatValueNode\\|GraphQL\\\\Language\\\\AST\\\\IntValueNode\\|GraphQL\\\\Language\\\\AST\\\\ListValueNode\\|GraphQL\\\\Language\\\\AST\\\\NullValueNode\\|GraphQL\\\\Language\\\\AST\\\\ObjectValueNode\\|GraphQL\\\\Language\\\\AST\\\\StringValueNode\\|GraphQL\\\\Language\\\\AST\\\\VariableNode given\\.$#"
815-
count: 1
816-
path: src/Utils/ASTDefinitionBuilder.php
817-
818813
-
819814
message: "#^Anonymous function should have native return typehint \"bool\"\\.$#"
820815
count: 2

src/Language/AST/InputValueDefinitionNode.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ class InputValueDefinitionNode extends Node
1515
/** @var NamedTypeNode|ListTypeNode|NonNullTypeNode */
1616
public $type;
1717

18-
/** @var VariableNode|NullValueNode|IntValueNode|FloatValueNode|StringValueNode|BooleanValueNode|EnumValueNode|ListValueNode|ObjectValueNode */
18+
/** @var VariableNode|NullValueNode|IntValueNode|FloatValueNode|StringValueNode|BooleanValueNode|EnumValueNode|ListValueNode|ObjectValueNode|null */
1919
public $defaultValue;
2020

2121
/** @var DirectiveNode[] */

src/Utils/ASTDefinitionBuilder.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -472,7 +472,7 @@ public function buildInputField(InputValueDefinitionNode $value) : array
472472
'astNode' => $value,
473473
];
474474

475-
if ($value->defaultValue) {
475+
if ($value->defaultValue !== null) {
476476
$config['defaultValue'] = $value->defaultValue;
477477
}
478478

0 commit comments

Comments
 (0)