refactor(schedule): simplify cache cleaner and improve file handling#434
Merged
Conversation
…es/removeOldest, improve logging and comments
Member
|
Sorry for the long delay, nice work, thanks for PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced Walk with WalkDir, added listFiles and removeOldest to collect and delete files by modification time, and consolidated cache-cleaning logic. Improved logging and error handling so the cleaner reliably removes the oldest files until the cache size limit is met and handles missing paths gracefully.
note: the previous implementation could exhibit O(n^2) behavior due to repeated directory scans; this refactor reduces redundant passes and improves performance.