Skip to content
This repository was archived by the owner on Jul 13, 2021. It is now read-only.

[WiP] HMR in a webworker#104

Open
yurynix wants to merge 2 commits into
webpack-contrib:masterfrom
yurynix:fix/window-global-webworker
Open

[WiP] HMR in a webworker#104
yurynix wants to merge 2 commits into
webpack-contrib:masterfrom
yurynix:fix/window-global-webworker

Conversation

@yurynix

@yurynix yurynix commented Oct 22, 2018

Copy link
Copy Markdown

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update
  • Replaces window -> (typeof self !== 'undefined' ? self : this)
  • Upgrades loglevelnext to 3.0.0

Motivation / Use-Case

I'm developing an app that is being executed in a webworker, so I don't have a window global available, I set target: 'webworker' in webpack.config and serving the file via webpack-dev-middleware on express.

This is a test branch to see if I can make it work.

Breaking Changes

TBD

Additional Info

This is useful for environments that doesn't
have window as global, like webworkers.
@alexander-akait

Copy link
Copy Markdown
Member

@yurynix hi, how you can use webpack-hot-client?

@jsf-clabot

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants