test: fix (#1155)

Author: alexander-akait

package-lock.json

@@ -77,12 +77,12 @@
     "eslint-config-webpack": "^4.4.2",
     "eslint-plugin-import": "^2.32.0",
     "eslint-plugin-jest": "^29.0.1",
-    "eslint-plugin-jsdoc": "^52.0.0",
+    "eslint-plugin-jsdoc": "^62.0.0",
     "eslint-plugin-n": "^17.21.0",
     "eslint-plugin-prettier": "^5.5.3",
-    "eslint-plugin-unicorn": "^60.0.0",
+    "eslint-plugin-unicorn": "^62.0.0",
     "file-loader": "^6.2.0",
-    "globals": "^16.3.0",
+    "globals": "^17.0.0",
     "husky": "^7.0.0",
     "jest": "^28.1.3",
     "jest-environment-jsdom": "^28.1.3",

package.json

@@ -13,7 +13,7 @@ const noDocument = typeof document === "undefined";
 
 const { forEach } = Array.prototype;
 
-// eslint-disable-next-line jsdoc/no-restricted-syntax
+/* eslint-disable jsdoc/reject-function-type */
 /**
  * @param {Function} fn any function
  * @param {number} time time
@@ -38,6 +38,7 @@ function debounce(fn, time) {
     timeout = setTimeout(functionCall, time);
   };
 }
+/* eslint-enable jsdoc/reject-function-type */
 
 /**
  * @returns {void}

src/hmr/hotModuleReplacement.js

@@ -89,7 +89,7 @@ const CODE_GENERATION_RESULT = {
   runtimeRequirements: new Set(),
 };
 
-// eslint-disable-next-line jsdoc/no-restricted-syntax
+// eslint-disable-next-line jsdoc/reject-any-type
 /** @typedef {{ context: string | null, identifier: string, identifierIndex: number, content: Buffer, sourceMap?: Buffer, media?: string, supports?: string, layer?: any, assetsInfo?: Map<string, AssetInfo>, assets?: { [key: string]: Source }}} CssModuleDependency */
 /** @typedef {Module & { content: Buffer, media?: string, sourceMap?: Buffer, supports?: string, layer?: string, assets?: { [key: string]: Source }, assetsInfo?: Map<string, AssetInfo> }} CssModule */
 /** @typedef {{ new(dependency: CssModuleDependency): CssModule }} CssModuleConstructor */
@@ -795,7 +795,7 @@ class MiniCssExtractPlugin {
           compilation.runtimeTemplate.requestShortener,
         );
 
-        if (modules.size > 0) {
+        if (modules && modules.size > 0) {
           const { hashFunction, hashDigest, hashDigestLength } = outputOptions;
           const { createHash } = compiler.webpack.util;
           const hash = createHash(/** @type {string} */ (hashFunction));

src/index.js

@@ -24,10 +24,10 @@ const MiniCssExtractPlugin = require("./index");
 /** @typedef {import("webpack").NormalModule} NormalModule */
 /** @typedef {import("./index.js").LoaderOptions} LoaderOptions */
 
-// eslint-disable-next-line jsdoc/no-restricted-syntax
+// eslint-disable-next-line jsdoc/reject-function-type
 /** @typedef {{[key: string]: string | Function }} Locals */
 
-// eslint-disable-next-line jsdoc/no-restricted-syntax
+// eslint-disable-next-line jsdoc/reject-any-type
 /** @typedef {any} EXPECTED_ANY */
 
 /**

src/loader.js

@@ -4,7 +4,7 @@ const path = require("path");
 /** @typedef {import("webpack").Compilation} Compilation */
 /** @typedef {import("webpack").Module} Module */
 
-// eslint-disable-next-line jsdoc/no-restricted-syntax
+// eslint-disable-next-line jsdoc/reject-any-type
 /** @typedef {import("webpack").LoaderContext<any>} LoaderContext */
 
 /**
@@ -36,7 +36,7 @@ function findModuleById(compilation, id) {
   return null;
 }
 
-// eslint-disable-next-line jsdoc/no-restricted-syntax
+/* eslint-disable jsdoc/reject-any-type */
 /**
  * @param {LoaderContext} loaderContext loader context
  * @param {string | Buffer} code code
@@ -54,6 +54,7 @@ function evalModuleCode(loaderContext, code, filename) {
 
   return module.exports;
 }
+/* eslint-enable jsdoc/reject-any-type */
 
 /**
  * @param {string} a a
@@ -203,14 +204,15 @@ function getUndoPath(filename, outputPath, enforceRelative) {
       : append;
 }
 
-// eslint-disable-next-line jsdoc/no-restricted-syntax
+/* eslint-disable jsdoc/reject-function-type */
 /**
  * @param {string | Function} value local
  * @returns {string} stringified local
  */
 function stringifyLocal(value) {
   return typeof value === "function" ? value.toString() : JSON.stringify(value);
 }
+/* eslint-enable jsdoc/reject-function-type */
 
 /**
  * @param {string} str string

src/utils.js

@@ -2,7 +2,6 @@
  * @jest-environment jsdom
  */
 /* global document */
-/* eslint-env browser */
 
 import hotModuleReplacement from "../src/hmr/hotModuleReplacement";
 import { hotLoader } from "../src/loader";

test/HMR.test.js

@@ -1,35 +1,5 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`emit option should invalidate the cache with disabled "emit" option: assets 1`] = `
-Array [
-  "main.js",
-  "static/react.svg",
-]
-`;
-
-exports[`emit option should invalidate the cache with disabled "emit" option: assets 2`] = `
-Array [
-  "main.js",
-]
-`;
-
-exports[`emit option should invalidate the cache with disabled "emit" option: emittedAssets 1`] = `
-Array [
-  "main.js",
-  "static/react.svg",
-]
-`;
-
-exports[`emit option should invalidate the cache with disabled "emit" option: emittedAssets 2`] = `Array []`;
-
-exports[`emit option should invalidate the cache with disabled "emit" option: errors 1`] = `Array []`;
-
-exports[`emit option should invalidate the cache with disabled "emit" option: errors 2`] = `Array []`;
-
-exports[`emit option should invalidate the cache with disabled "emit" option: warnings 1`] = `Array []`;
-
-exports[`emit option should invalidate the cache with disabled "emit" option: warnings 2`] = `Array []`;
-
 exports[`emit option should work when emit option is "false": assets 1`] = `
 Array [
   "main.js",

test/__snapshots__/emit-option.test.js.snap

@@ -1,13 +1,13 @@
 "use strict";
 (self["webpackChunk"] = self["webpackChunk"] || []).push([[0],{
 
-/***/ 2:
-/***/ ((__unused_webpack_module, __webpack_exports__, __webpack_require__) => {
+/***/ 2
+(__unused_webpack_module, __webpack_exports__, __webpack_require__) {
 
 __webpack_require__.r(__webpack_exports__);
 // extracted by mini-css-extract-plugin
 
 
-/***/ })
+/***/ }
 
 }]);

test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/async.js

@@ -1,13 +1,13 @@
 "use strict";
 (self["webpackChunk"] = self["webpackChunk"] || []).push([[0],{
 
-/***/ 2:
-/***/ ((__unused_webpack_module, __webpack_exports__, __webpack_require__) => {
+/***/ 2
+(__unused_webpack_module, __webpack_exports__, __webpack_require__) {
 
 __webpack_require__.r(__webpack_exports__);
 // extracted by mini-css-extract-plugin
 
 
-/***/ })
+/***/ }
 
 }]);