Skip to content

Commit 5ff6ebc

Browse files
committed
ci: allow Node 10/12 test rows to fail without blocking the workflow
Some bundled CSS minimizers (`@swc/css` requires Node 14+, `esbuild` 0.27 requires Node 18+) cannot load on Node 10/12. The matrix still exercises those Node versions for visibility, and `fail-fast` is now disabled so newer rows aren't cancelled when an older row fails.
1 parent 436dacb commit 5ff6ebc

1 file changed

Lines changed: 7 additions & 0 deletions

File tree

.github/workflows/nodejs.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,13 +65,20 @@ jobs:
6565
name: Test - ${{ matrix.os }} - Node v${{ matrix.node-version }}, Webpack ${{ matrix.webpack-version }}
6666

6767
strategy:
68+
fail-fast: false
6869
matrix:
6970
os: [ubuntu-latest, windows-latest, macos-latest]
7071
node-version: [10.x, 12.x, 14.x, 16.x, 18.x, 20.x, 22.x, 24.x]
7172
webpack-version: [latest]
7273

7374
runs-on: ${{ matrix.os }}
7475

76+
# Some of the bundled CSS minimizers (`@swc/css`, `esbuild`, etc.)
77+
# require Node 14+; let those rows run for visibility but don't fail
78+
# the workflow when they break on the legacy Node versions we still
79+
# try to support for the JS minimizers.
80+
continue-on-error: ${{ matrix.node-version == '10.x' || matrix.node-version == '12.x' }}
81+
7582
concurrency:
7683
group: test-${{ matrix.os }}-v${{ matrix.node-version }}-${{ matrix.webpack-version }}-${{ github.ref }}
7784
cancel-in-progress: true

0 commit comments

Comments
 (0)