test: cover multi-asset minify and js-only minimizer fallback#671
Merged
alexander-akait merged 2 commits intomainfrom May 8, 2026
Merged
test: cover multi-asset minify and js-only minimizer fallback#671alexander-akait merged 2 commits intomainfrom
alexander-akait merged 2 commits intomainfrom
Conversation
Adds two tests using a shared `multi-asset` entry that emits js, json, css, and html. The first wires up dedicated minimizers for each type and asserts they all get minified. The second uses only the default TerserPlugin (js) and asserts non-js assets pass through untouched without errors. https://claude.ai/code/session_01Wa5WuhunnggPcf7DLrx6Ri
Replaces the four-instance setup with one TerserPlugin that takes an array of minimizers. Each built-in minimizer's `.filter` dispatches the asset to the right one, so js/json/css/html all get minified in one pass. Switches the css minimizer to `cleanCssMinify` because Jest 27's resolver can't follow `cssnano`'s subpath-`exports` dependency on `@colordx/core/plugins/*` when the chain runs inline (jsonMinify disables workers for the whole array). https://claude.ai/code/session_01Wa5WuhunnggPcf7DLrx6Ri
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #671 +/- ##
=======================================
Coverage 96.11% 96.11%
=======================================
Files 3 3
Lines 592 592
Branches 201 201
=======================================
Hits 569 569
Misses 21 21
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two tests using a shared
multi-assetentry that emits js, json,css, and html. The first wires up dedicated minimizers for each type
and asserts they all get minified. The second uses only the default
TerserPlugin (js) and asserts non-js assets pass through untouched
without errors.
https://claude.ai/code/session_01Wa5WuhunnggPcf7DLrx6Ri