refactor: restore logic

Author: alexander-akait

packages/webpack-cli/src/webpack-cli.ts

@@ -878,7 +878,7 @@ class WebpackCLI {
       const optionForCommand = new Option(mainOption.flags, mainOption.description);
 
       // Hide stub option
-      optionForCommand.flags = "";
+      // TODO find a solution to hide such options in the new commander version, for example `--performance` and `--no-performance` because we don't have `--performance` at all
       optionForCommand.hidden = option.hidden || true;
       (optionForCommand as Option & { internal?: boolean }).internal = true;
 

test/build/core-flags/core-flags.test.js

@@ -108,7 +108,7 @@ describe("core flags", () => {
       const { exitCode, stderr, stdout } = await run(__dirname, ["--amd"]);
 
       expect(exitCode).toBe(2);
-      expect(stderr).toContain("Unknown option '--amd");
+      expect(stderr).toContain("Invalid value 'true' for the '--amd' option");
       expect(stdout).toBeFalsy();
     });
 
@@ -195,24 +195,6 @@ describe("core flags", () => {
     });
   });
 
-  describe("only negative flags", () => {
-    it("should throw an error on set performance to true", async () => {
-      const { exitCode, stderr, stdout } = await run(__dirname, ["--performance"]);
-
-      expect(exitCode).toBe(2);
-      expect(stderr).toContain("Unknown option '--performance'");
-      expect(stdout).toBeFalsy();
-    });
-
-    it("should set performance to false", async () => {
-      const { exitCode, stderr, stdout } = await run(__dirname, ["--no-performance"]);
-
-      expect(exitCode).toBe(0);
-      expect(stderr).toBeFalsy();
-      expect(stdout).toContain("performance: false");
-    });
-  });
-
   describe("flags with multiple types", () => {
     it("should allow string value for `infrastructureLogging.debug`", async () => {
       const { exitCode, stderr, stdout } = await run(__dirname, [