Skip to content

Commit dacbb4b

Browse files
chore: remove unused code (#4463)
1 parent 5540430 commit dacbb4b

2 files changed

Lines changed: 2 additions & 27 deletions

File tree

packages/webpack-cli/src/types.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ interface IWebpackCLI {
4343
toKebabCase: StringFormatter;
4444
capitalizeFirstLetter: StringFormatter;
4545
checkPackageExists(packageName: string): boolean;
46-
getAvailablePackageManagers(): PackageManager[];
4746
getDefaultPackageManager(): PackageManager | undefined;
4847
doInstall(packageName: string, options?: PackageInstallOptions): Promise<string>;
4948
loadJSONFile<T = unknown>(path: Path, handleError: boolean): Promise<T>;

packages/webpack-cli/src/webpack-cli.ts

Lines changed: 2 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -184,33 +184,7 @@ class WebpackCLI implements IWebpackCLI {
184184
return false;
185185
}
186186

187-
getAvailablePackageManagers(): PackageManager[] {
188-
const { sync } = require("cross-spawn");
189-
const installers: PackageManager[] = ["npm", "yarn", "pnpm"];
190-
const hasPackageManagerInstalled = (packageManager: PackageManager) => {
191-
try {
192-
sync(packageManager, ["--version"]);
193-
194-
return packageManager;
195-
} catch (_err) {
196-
return false;
197-
}
198-
};
199-
const availableInstallers = installers.filter((installer) =>
200-
hasPackageManagerInstalled(installer),
201-
);
202-
203-
if (!availableInstallers.length) {
204-
this.logger.error("No package manager found.");
205-
206-
process.exit(2);
207-
}
208-
209-
return availableInstallers;
210-
}
211-
212187
getDefaultPackageManager(): PackageManager | undefined {
213-
const { sync } = require("cross-spawn");
214188
const hasLocalNpm = fs.existsSync(path.resolve(process.cwd(), "package-lock.json"));
215189

216190
if (hasLocalNpm) {
@@ -229,6 +203,8 @@ class WebpackCLI implements IWebpackCLI {
229203
return "pnpm";
230204
}
231205

206+
const { sync } = require("cross-spawn");
207+
232208
try {
233209
// the sync function below will fail if npm is not installed,
234210
// an error will be thrown

0 commit comments

Comments
 (0)