refactor!: version command only output versions

Author: alexander-akait

packages/webpack-cli/src/webpack-cli.ts

@@ -83,14 +83,14 @@ const runTest = async (pkg, cliArgs = [], logMessage = undefined, isSubPackage =
   });
 };
 
-const runTestStdout = async ({ packageName, cliArgs, logMessage, isSubPackage } = {}) => {
+const runTestStdout = async ({ packageName, cliArgs, logMessage, isSubPackage, cwd } = {}) => {
   // Simulate package missing
   swapPkgName(packageName, isSubPackage);
 
   const { execa } = await import("execa");
   const abortController = new AbortController();
   const proc = execa(CLI_ENTRY_PATH, cliArgs, {
-    cwd: __dirname,
+    cwd: cwd || __dirname,
     reject: false,
     cancelSignal: abortController.signal,
   });

smoketests/helpers.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const path = require("node:path");
+
 const { runTest, runTestStdout } = require("../helpers");
 
 const noCommand = () => {
@@ -37,9 +39,14 @@ const serveCommand = () => {
 const versionCommand = () => {
   const packageName = "webpack";
   const args = ["version"];
-  const logMessage = "System:";
-
-  return runTestStdout({ packageName, cliArgs: args, logMessage });
+  const logMessage = "webpack:";
+
+  return runTestStdout({
+    packageName,
+    cliArgs: args,
+    logMessage,
+    cwd: path.resolve(__dirname, "../../"),
+  });
 };
 
 const helpCommand = () => {

smoketests/missing-packages/webpack.test.js

@@ -16,7 +16,7 @@ const spawnMock = jest.fn();
 
 jest.mock("cross-spawn", () => ({ sync: spawnMock }));
 
-describe("doInstall", () => {
+describe("installPackage", () => {
   let cli;
   let getDefaultPackageManagerSpy;
 
@@ -36,7 +36,7 @@ describe("doInstall", () => {
     readlineQuestionMock.mockImplementation((_questionTest, cb) => cb("y"));
     getDefaultPackageManagerSpy.mockResolvedValue("npm");
 
-    const installResult = await cli.doInstall("test-package");
+    const installResult = await cli.installPackage("test-package");
 
     expect(installResult).toBe("test-package");
     expect(readlineQuestionMock).toHaveBeenCalledTimes(1);
@@ -54,7 +54,7 @@ describe("doInstall", () => {
     readlineQuestionMock.mockImplementation((_questionTest, cb) => cb("y"));
     getDefaultPackageManagerSpy.mockReturnValue("yarn");
 
-    const installResult = await cli.doInstall("test-package");
+    const installResult = await cli.installPackage("test-package");
 
     expect(installResult).toBe("test-package");
     expect(readlineQuestionMock).toHaveBeenCalledTimes(1);
@@ -72,7 +72,7 @@ describe("doInstall", () => {
     readlineQuestionMock.mockImplementation((_questionTest, cb) => cb("y"));
     getDefaultPackageManagerSpy.mockReturnValue("pnpm");
 
-    const installResult = await cli.doInstall("test-package");
+    const installResult = await cli.installPackage("test-package");
 
     expect(installResult).toBe("test-package");
     expect(readlineQuestionMock).toHaveBeenCalledTimes(1);
@@ -91,7 +91,7 @@ describe("doInstall", () => {
     getDefaultPackageManagerSpy.mockReturnValue("npm");
 
     const preMessage = jest.fn();
-    const installResult = await cli.doInstall("test-package", { preMessage });
+    const installResult = await cli.installPackage("test-package", { preMessage });
 
     expect(installResult).toBe("test-package");
     expect(preMessage).toHaveBeenCalledTimes(1);
@@ -110,7 +110,7 @@ describe("doInstall", () => {
     readlineQuestionMock.mockImplementation((_questionTest, cb) => cb("y"));
     getDefaultPackageManagerSpy.mockReturnValue("npm");
 
-    const installResult = await cli.doInstall("test-package");
+    const installResult = await cli.installPackage("test-package");
 
     expect(installResult).toBe("test-package");
     expect(readlineQuestionMock).toHaveBeenCalledTimes(1);
@@ -128,7 +128,7 @@ describe("doInstall", () => {
     readlineQuestionMock.mockImplementation((_questionTest, cb) => cb("yes"));
     getDefaultPackageManagerSpy.mockReturnValue("npm");
 
-    const installResult = await cli.doInstall("test-package");
+    const installResult = await cli.installPackage("test-package");
 
     expect(installResult).toBe("test-package");
     expect(readlineQuestionMock).toHaveBeenCalledTimes(1);
@@ -146,7 +146,7 @@ describe("doInstall", () => {
     readlineQuestionMock.mockImplementation((_questionTest, cb) => cb("yEs"));
     getDefaultPackageManagerSpy.mockReturnValue("npm");
 
-    const installResult = await cli.doInstall("test-package");
+    const installResult = await cli.installPackage("test-package");
 
     expect(installResult).toBe("test-package");
     expect(readlineQuestionMock).toHaveBeenCalledTimes(1);
@@ -164,7 +164,7 @@ describe("doInstall", () => {
     readlineQuestionMock.mockImplementation((_questionTest, cb) => cb("n"));
 
     const mockExit = jest.spyOn(process, "exit").mockImplementation(() => {});
-    const installResult = await cli.doInstall("test-package");
+    const installResult = await cli.installPackage("test-package");
 
     expect(installResult).toBeUndefined();
     expect(readlineQuestionMock).toHaveBeenCalledTimes(1);
@@ -179,7 +179,7 @@ describe("doInstall", () => {
     readlineQuestionMock.mockImplementation((_questionTest, cb) => cb("n"));
 
     const mockExit = jest.spyOn(process, "exit").mockImplementation(() => {});
-    const installResult = await cli.doInstall("test-package");
+    const installResult = await cli.installPackage("test-package");
 
     expect(installResult).toBeUndefined();
     expect(readlineQuestionMock).toHaveBeenCalledTimes(1);
@@ -194,7 +194,7 @@ describe("doInstall", () => {
     readlineQuestionMock.mockImplementation((_questionTest, cb) => cb("no"));
 
     const mockExit = jest.spyOn(process, "exit").mockImplementation(() => {});
-    const installResult = await cli.doInstall("test-package");
+    const installResult = await cli.installPackage("test-package");
 
     expect(installResult).toBeUndefined();
     expect(readlineQuestionMock).toHaveBeenCalledTimes(1);
@@ -209,7 +209,7 @@ describe("doInstall", () => {
     readlineQuestionMock.mockImplementation((_questionTest, cb) => cb("No"));
 
     const mockExit = jest.spyOn(process, "exit").mockImplementation(() => {});
-    const installResult = await cli.doInstall("test-package");
+    const installResult = await cli.installPackage("test-package");
 
     expect(installResult).toBeUndefined();
     expect(readlineQuestionMock).toHaveBeenCalledTimes(1);