Closed
Conversation
evenstensberg
requested changes
May 13, 2025
Member
evenstensberg
left a comment
evenstensberg
left a comment
There was a problem hiding this comment.
Failing CI (v24) needs fix
| matrix: | ||
| os: [ubuntu-latest, windows-latest, macos-latest] | ||
| node-version: [18.x, 20.x, 22.x, 23.x] | ||
| node-version: [18.x, 20.x, 22.x, 24.x] |
Member
There was a problem hiding this comment.
Why skip 23? Just append v24
Member
There was a problem hiding this comment.
Done here - #4456
We usually run tests only on LTS + last version, now we have 24 version (i.e. LTS and last version), so 23 version is not supported anymore, and there is no sense to test it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
CI
Did you add tests for your changes?
Run on node 24
If relevant, did you update the documentation?
NA
Summary
Add node.js 24 in ci pipeline
Does this PR introduce a breaking change?
NA
Other information
NA