Skip to content

Commit 0236ee3

Browse files
bjohansebasclaude
andcommitted
test(e2e): collapse the rebuilding path in console snapshots
webpack's invalid hook sometimes reports the watched directory instead of the changed file under the polling watcher, so the "bundle rebuilding (…)" line alternated between the file and the fixture dir and flaked the snapshots. The normalizer now collapses both forms to "(<fixture> changed)". Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 parent 981a25f commit 0236ee3

4 files changed

Lines changed: 14 additions & 8 deletions

File tree

test/e2e/__snapshots__/client.test.js.snap.webpack5

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ exports[`hot client (browser) reconnects manually with setOptionsAndConnect() af
1414
[
1515
"[webpack-dev-middleware] connected",
1616
"[webpack-dev-middleware] connected",
17-
"[webpack-dev-middleware] bundle rebuilding (<fixture>/app.js changed)",
17+
"[webpack-dev-middleware] bundle rebuilding (<fixture> changed)",
1818
"[webpack-dev-middleware] bundle rebuilt in Xms",
1919
"[webpack-dev-middleware] Checking for updates on the server...",
2020
"[webpack-dev-middleware] Hot updated 1 modules.",

test/e2e/__snapshots__/logging.test.js.snap.webpack5

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ You may need an appropriate loader to handle this file type, currently no loader
1313
exports[`client logging (browser) logging=log adds the collapsed per-module detail 1`] = `
1414
[
1515
"[webpack-dev-middleware] connected",
16-
"[webpack-dev-middleware] bundle rebuilding (<fixture>/app.js changed)",
16+
"[webpack-dev-middleware] bundle rebuilding (<fixture> changed)",
1717
"[webpack-dev-middleware] bundle rebuilt in Xms",
1818
"[webpack-dev-middleware] Checking for updates on the server...",
1919
"[webpack-dev-middleware] Hot updated 1 modules.",
@@ -37,7 +37,7 @@ Critical dependency: the request of a dependency is an expression",
3737
exports[`client logging (browser) logs a full update cycle at the default info level, with the prefix 1`] = `
3838
[
3939
"[webpack-dev-middleware] connected",
40-
"[webpack-dev-middleware] bundle rebuilding (<fixture>/app.js changed)",
40+
"[webpack-dev-middleware] bundle rebuilding (<fixture> changed)",
4141
"[webpack-dev-middleware] bundle rebuilt in Xms",
4242
"[webpack-dev-middleware] Checking for updates on the server...",
4343
"[webpack-dev-middleware] Hot updated 1 modules.",

test/e2e/__snapshots__/multi-compiler.test.js.snap.webpack5

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,15 @@ exports[`multi-compiler (browser) logs per-bundle lifecycles and deduplicates wa
66
"[webpack-dev-middleware] bundle 'widget' has 1 warnings",
77
"[webpack-dev-middleware] ./entry.js 11:8-20
88
Critical dependency: the request of a dependency is an expression",
9-
"[webpack-dev-middleware] bundle 'app' rebuilding (<fixture>/app/entry.js changed)",
10-
"[webpack-dev-middleware] bundle 'app' rebuilding (<fixture>/app/entry.js changed)",
9+
"[webpack-dev-middleware] bundle 'app' rebuilding (<fixture> changed)",
10+
"[webpack-dev-middleware] bundle 'app' rebuilding (<fixture> changed)",
1111
"[webpack-dev-middleware] bundle 'app' rebuilt in Xms",
1212
"[webpack-dev-middleware] Checking for updates on the server...",
1313
"[webpack-dev-middleware] bundle 'app' rebuilt in Xms",
1414
"[webpack-dev-middleware] Hot updated 1 modules.",
1515
"[webpack-dev-middleware] App is up to date.",
16-
"[webpack-dev-middleware] bundle 'widget' rebuilding (<fixture>/widget/entry.js changed)",
17-
"[webpack-dev-middleware] bundle 'widget' rebuilding (<fixture>/widget/entry.js changed)",
16+
"[webpack-dev-middleware] bundle 'widget' rebuilding (<fixture> changed)",
17+
"[webpack-dev-middleware] bundle 'widget' rebuilding (<fixture> changed)",
1818
"[webpack-dev-middleware] bundle 'widget' rebuilt in Xms",
1919
"[webpack-dev-middleware] bundle 'widget' rebuilt in Xms",
2020
"[webpack-dev-middleware] Checking for updates on the server...",

test/helpers/console-collector.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,13 @@ function normalizeConsole(messages) {
5757
.map((text) =>
5858
text
5959
.replaceAll(/\d+\s?ms/g, "Xms")
60-
.replaceAll(/[^\s(]*wdm-e2e-[^/\s]*/g, "<fixture>"),
60+
.replaceAll(/[^\s(]*wdm-e2e-[^/\s]*/g, "<fixture>")
61+
// The invalid hook sometimes reports the watched directory instead of
62+
// the file (polling watcher) — collapse both forms.
63+
.replaceAll(
64+
/rebuilding \(<fixture>\S* changed\)/g,
65+
"rebuilding (<fixture> changed)",
66+
),
6167
);
6268
}
6369

0 commit comments

Comments
 (0)