test(e2e): keyboard pagination, paginate=false, and the cross-copy runtime filter

Arrow keys page through problems with real keyboard events (the frame
holds focus after the pager click), paginate=false shows the full
problem list with no counter, and a runtime filter configured by a
later bundled copy is honored by the window listeners the first copy
attached — proven non-vacuously by first catching an error through
copy A, then watching copy B's rejecting filter keep the overlay away.
The three jsdom equivalents are removed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Author: bjohansebas

test/e2e/overlay.test.js

@@ -313,11 +313,58 @@ describe("error overlay (browser)", () => {
       document.body.textContent.includes("2 / 2"),
     );
 
+    // Real keyboard navigation — the frame has focus after the click.
+    await page.keyboard.press("ArrowLeft");
+    await frame.waitForFunction(() =>
+      document.body.textContent.includes("1 / 2"),
+    );
+    await page.keyboard.press("ArrowRight");
+    await frame.waitForFunction(() =>
+      document.body.textContent.includes("2 / 2"),
+    );
+
     expect(await frame.evaluate(() => document.body.textContent)).toContain(
       "2 / 2",
     );
   });
 
+  it("shows the full problem list when paginate=false", async () => {
+    hotApp = await createHotApp({
+      query: '?overlay={"paginate":false}',
+      code: `
+        try {
+          require("./a");
+        } catch (err) {
+          // expected
+        }
+        try {
+          require("./b");
+        } catch (err) {
+          // expected
+        }
+      `,
+      files: {
+        "a.js": "broken a {{{",
+        "b.js": "broken b {{{",
+      },
+    });
+    ({ page, browser } = await runBrowser());
+
+    await page.goto(hotApp.url);
+
+    const frame = await waitForOverlay(page);
+    await frame.waitForFunction(
+      () =>
+        document.body.textContent.includes("broken a {{{") &&
+        document.body.textContent.includes("broken b {{{"),
+    );
+
+    // Both problems at once, no pager.
+    expect(await frame.evaluate(() => document.body.textContent)).not.toContain(
+      "1 / 2",
+    );
+  });
+
   it("accumulates runtime errors and pages between them", async () => {
     hotApp = await createHotApp({
       code: `
@@ -453,7 +500,12 @@ describe("overlay shared state across bundled copies (browser)", () => {
    * @returns {string} app source
    */
   const exposeOverlay = (globalName) =>
-    `globalThis.${globalName} = require(${JSON.stringify(OVERLAY_ENTRY)});`;
+    `globalThis.${globalName} = require(${JSON.stringify(OVERLAY_ENTRY)});
+     globalThis.boom = (message) => {
+       setTimeout(() => {
+         throw new Error(message);
+       }, 0);
+     };`;
 
   const start = async () => {
     hotApp = await createHotApp({
@@ -605,6 +657,32 @@ describe("overlay shared state across bundled copies (browser)", () => {
     expect(await page.$(`#${OVERLAY_ID}`)).not.toBeNull();
   });
 
+  it("honors the runtime filter configured by a later copy", async () => {
+    await start();
+    await page.goto(hotApp.url);
+
+    // The first copy attaches the window listeners; a runtime error lands in
+    // the overlay, proving they are live.
+    await page.evaluate(() => {
+      globalThis.overlayA.default({ catchRuntimeError: true });
+      globalThis.boom("caught-by-A");
+    });
+    await page.waitForSelector(`#${OVERLAY_ID}`, { timeout: 30000 });
+    await page.evaluate(() => globalThis.overlayA.clear());
+
+    // A later copy swaps in a rejecting filter — the listeners the first
+    // copy attached must honor it.
+    await page.evaluate(() => {
+      globalThis.overlayB.default({ catchRuntimeError: () => false });
+      globalThis.boom("filtered-out");
+    });
+    await new Promise((resolve) => {
+      setTimeout(resolve, 500);
+    });
+
+    expect(await page.$(`#${OVERLAY_ID}`)).toBeNull();
+  });
+
   it("fills state fields missing from an older copy's shape", async () => {
     await start();
     // An older package version created a leaner shared state before the

test/overlay.test.js

@@ -170,30 +170,6 @@ describe("overlay", () => {
       expect(getCard().textContent).not.toContain("boom-before");
       expect(getCard().textContent).not.toContain("1 / 2");
     });
-
-    it("honors the runtime filter configured by a later copy", () => {
-      // The window listeners were attached by this copy…
-      configureOverlay({ catchRuntimeError: true });
-
-      // …but the filter comes from a second bundled copy of the module.
-      jest.resetModules();
-
-      const laterCopy = require("../client-src/overlay");
-
-      laterCopy.default({ catchRuntimeError: () => false });
-
-      globalThis.dispatchEvent(
-        new ErrorEvent("error", {
-          error: new Error("filtered-out"),
-          message: "filtered-out",
-        }),
-      );
-
-      expect(getOverlay()).toBeNull();
-
-      // Restore the plain-boolean configuration for the remaining tests.
-      configureOverlay({ catchRuntimeError: true });
-    });
   });
 
   describe("open in editor", () => {
@@ -274,20 +250,6 @@ describe("overlay", () => {
       expect(getCard().textContent).toContain("first boom");
     });
 
-    it("navigates with the arrow keys", () => {
-      showProblems("errors", ["first boom", "second boom"]);
-
-      getOverlay().contentDocument.dispatchEvent(
-        new KeyboardEvent("keydown", { key: "ArrowRight" }),
-      );
-      expect(getCard().textContent).toContain("second boom");
-
-      getOverlay().contentDocument.dispatchEvent(
-        new KeyboardEvent("keydown", { key: "ArrowLeft" }),
-      );
-      expect(getCard().textContent).toContain("first boom");
-    });
-
     it("resets to the first page on a new problem set", () => {
       showProblems("errors", ["first boom", "second boom"]);
 
@@ -313,15 +275,6 @@ describe("overlay", () => {
       expect(getCard().textContent).toContain("second boom");
       expect(getCard().textContent).toContain("2 / 2");
     });
-
-    it("shows the full list when disabled", () => {
-      configureOverlay({ paginate: false });
-      showProblems("errors", ["first boom", "second boom"]);
-
-      expect(getCard().textContent).toContain("first boom");
-      expect(getCard().textContent).toContain("second boom");
-      expect(getCard().textContent).not.toContain("1 / 2");
-    });
   });
 
   describe("configureOverlay", () => {