test: assert the dismiss hint where it is acted on

The Escape e2e now checks the card advertises the dismissal it is about
to perform; the jsdom hint test is removed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Author: bjohansebas

test/e2e/overlay.test.js

@@ -98,7 +98,12 @@ describe("error overlay (browser)", () => {
     await page.goto(hotApp.url);
 
     hotApp.edit("also broken {{{");
-    await waitForOverlay(page);
+    const frame = await waitForOverlay(page);
+
+    // The card advertises exactly what this test is about to do.
+    expect(await frame.evaluate(() => document.body.textContent)).toContain(
+      "Click outside, press Esc, or fix the code to dismiss.",
+    );
 
     await page.keyboard.press("Escape");
     await waitForNoOverlay(page);

test/overlay.test.js

@@ -93,13 +93,6 @@ describe("overlay", () => {
       expect(getCard().textContent).toContain("https://example.com/a.");
     });
 
-    it("shows a dismiss hint", () => {
-      showProblems("errors", ["boom"]);
-      expect(getCard().textContent).toContain(
-        "Click outside, press Esc, or fix the code to dismiss.",
-      );
-    });
-
     it("re-mounts the overlay when the iframe was removed without clear()", () => {
       showProblems("errors", ["boom"]);
       // A framework wiping `document.body` removes the iframe behind our back.