test: drop the hot unit tests the browser suites already prove

The building payload's file and compiler name are pinned by the e2e
console snapshots, sync-vs-built by the invalidate and multi-compiler
runs, custom publishes by the subscribe round-trip, and the event
stream's delivery, broadcast, and close behavior by the two-page and
instance.close() tests. The invalidate e2e now snapshots its console —
a file-less building line and a sync silent enough not to log. What
stays in hot.test.js is the transport level: headers, heartbeat frames,
the headersSent guard, duplicate-name pairing, and progress throttling.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Author: bjohansebas

test/e2e/__snapshots__/client.test.js.snap.webpack5

@@ -1,5 +1,12 @@
 // Jest Snapshot v1, https://jestjs.io/docs/snapshot-testing
 
+exports[`hot client (browser) rebuilds on instance.invalidate() and syncs connected pages as a no-op 1`] = `
+[
+  "[webpack-dev-middleware] connected",
+  "[webpack-dev-middleware] bundle rebuilding",
+]
+`;
+
 exports[`hot client (browser) reconnects after a server restart and syncs up on missed builds 1`] = `
 [
   "[webpack-dev-middleware] connected",

test/e2e/client.test.js

@@ -289,6 +289,10 @@ describe("hot client (browser)", () => {
       setTimeout(resolve, 500);
     });
 
+    // Two lines only: no file on the building event (nothing triggered it)
+    // and a sync so uneventful it does not even log.
+    expect(normalizeConsole(console_.messages)).toMatchSnapshot();
+
     expect(
       await page.evaluate(() => document.getElementById("app").textContent),
     ).toBe("v1");

test/hot.test.js

@@ -189,53 +189,6 @@ describe("hot middleware (unit)", () => {
       stream.close();
     });
 
-    it("publishes JSON payloads to attached clients", () => {
-      const stream = createEventStream(5000, noopLogger);
-      const writes = [];
-      const fakeRes = {
-        writableEnded: false,
-        write: (chunk) => writes.push(chunk),
-        writeHead: () => {},
-        end: () => {},
-      };
-      const fakeReq = {
-        httpVersion: "1.1",
-        socket: { setKeepAlive: () => {} },
-        on: () => {},
-      };
-
-      stream.handler(fakeReq, fakeRes);
-      stream.publish({ action: "built", hash: "abc" });
-
-      expect(writes.some((w) => w.includes('"action":"built"'))).toBe(true);
-      expect(writes.some((w) => w.includes('"hash":"abc"'))).toBe(true);
-
-      stream.close();
-    });
-
-    it("close ends connected clients", () => {
-      const stream = createEventStream(5000, noopLogger);
-      let ended = false;
-      const fakeRes = {
-        writableEnded: false,
-        write: () => {},
-        writeHead: () => {},
-        end: () => {
-          ended = true;
-        },
-      };
-      const fakeReq = {
-        httpVersion: "1.1",
-        socket: { setKeepAlive: () => {} },
-        on: () => {},
-      };
-
-      stream.handler(fakeReq, fakeRes);
-      stream.close();
-
-      expect(ended).toBe(true);
-    });
-
     it("sets Connection: keep-alive for HTTP/1 clients", () => {
       const stream = createEventStream(5000, noopLogger);
       const { headers } = attachClient(stream, { httpVersion: "1.1" });
@@ -250,25 +203,6 @@ describe("hot middleware (unit)", () => {
       stream.close();
     });
 
-    it("broadcasts events to every attached client", () => {
-      const stream = createEventStream(5000, noopLogger);
-      const clients = [
-        attachClient(stream),
-        attachClient(stream),
-        attachClient(stream),
-      ];
-
-      for (const c of clients) c.writes.length = 0;
-
-      stream.publish({ action: "built", hash: "xyz" });
-
-      for (const c of clients) {
-        expect(c.writes.some((w) => w.includes('"hash":"xyz"'))).toBe(true);
-      }
-
-      stream.close();
-    });
-
     it("logs client connect and disconnect with the active count", () => {
       const messages = [];
       const stream = createEventStream(5000, {
@@ -317,55 +251,6 @@ describe("createHot", () => {
     hot.close();
   });
 
-  it("exposes publish() so callers can broadcast custom payloads", () => {
-    const compiler = makeFakeCompiler();
-    const hot = createHot(compiler, {});
-    const { writes } = attachClient({ handler: hot.handle });
-
-    hot.publish({ action: "custom-thing", payload: 42 });
-
-    expect(
-      writes.some(
-        (w) =>
-          w.includes('"action":"custom-thing"') && w.includes('"payload":42'),
-      ),
-    ).toBe(true);
-
-    hot.close();
-  });
-
-  it("includes the changed file in the building payload", () => {
-    const compiler = makeFakeCompiler();
-    const hot = createHot(compiler, {});
-    const { writes } = attachClient({ handler: hot.handle });
-
-    compiler.emitInvalid("/src/index.js");
-
-    expect(
-      writes.some(
-        (w) =>
-          w.includes('"action":"building"') &&
-          w.includes('"file":"/src/index.js"'),
-      ),
-    ).toBe(true);
-
-    hot.close();
-  });
-
-  it("omits the file field when the invalid hook reports none", () => {
-    const compiler = makeFakeCompiler();
-    const hot = createHot(compiler, {});
-    const { writes } = attachClient({ handler: hot.handle });
-
-    compiler.emitInvalid();
-
-    const building = writes.find((w) => w.includes('"action":"building"'));
-    expect(building).toBeDefined();
-    expect(building).not.toContain('"file"');
-
-    hot.close();
-  });
-
   it("ends a response whose headers were already sent instead of registering it", async () => {
     const compiler = makeFakeCompiler();
     const hot = createHot(compiler, {});
@@ -399,61 +284,6 @@ describe("createHot", () => {
     });
   });
 
-  it("includes the compilation name in the building payload", () => {
-    const compiler = makeFakeCompiler();
-    compiler.name = "main";
-    const hot = createHot(compiler, {});
-    const { writes } = attachClient({ handler: hot.handle });
-
-    compiler.emitInvalid();
-
-    // The client pairs `building` with the `built`/`sync` that follows by
-    // name — without it the building indicator can never be hidden.
-    const building = writes.find((w) => w.includes('"action":"building"'));
-    expect(building).toContain('"name":"main"');
-
-    hot.close();
-  });
-
-  it("names the building payload after the compiler that invalidated in a multi-compiler", () => {
-    const app = makeFakeCompiler();
-    app.name = "app";
-    const widget = makeFakeCompiler();
-    widget.name = "widget";
-    const multi = makeFakeCompiler();
-    multi.compilers = [app, widget];
-    const hot = createHot(multi, {});
-    const { writes } = attachClient({ handler: hot.handle });
-
-    widget.emitInvalid("/src/widget.js");
-
-    const building = writes.filter((w) => w.includes('"action":"building"'));
-    expect(building).toHaveLength(1);
-    expect(building[0]).toContain('"name":"widget"');
-    expect(building[0]).toContain('"file":"/src/widget.js"');
-
-    hot.close();
-  });
-
-  it("publishes sync instead of built when a bundle's hash did not change", () => {
-    const compiler = makeFakeCompiler();
-    const hot = createHot(compiler, {});
-    const { writes } = attachClient({ handler: hot.handle });
-
-    compiler.emitDone(makeFakeStats({ hash: "same" }));
-    writes.length = 0;
-
-    // A rebuild that produced the same hash (e.g. another bundle of a
-    // multi-compiler changed) must not be announced as `built`.
-    compiler.emitInvalid();
-    compiler.emitDone(makeFakeStats({ hash: "same" }));
-
-    expect(writes.some((w) => w.includes('"action":"sync"'))).toBe(true);
-    expect(writes.some((w) => w.includes('"action":"built"'))).toBe(false);
-
-    hot.close();
-  });
-
   it("pairs bundles sharing a name by occurrence so unchanged ones publish sync", () => {
     const compiler = makeFakeCompiler();
     const hot = createHot(compiler, {});
@@ -481,26 +311,6 @@ describe("createHot", () => {
     hot.close();
   });
 
-  it("publishes built when the bundle's hash changed", () => {
-    const compiler = makeFakeCompiler();
-    const hot = createHot(compiler, {});
-    const { writes } = attachClient({ handler: hot.handle });
-
-    compiler.emitDone(makeFakeStats({ hash: "one" }));
-    writes.length = 0;
-
-    compiler.emitInvalid();
-    compiler.emitDone(makeFakeStats({ hash: "two" }));
-
-    expect(
-      writes.some(
-        (w) => w.includes('"action":"built"') && w.includes('"hash":"two"'),
-      ),
-    ).toBe(true);
-
-    hot.close();
-  });
-
   it("publishes built only for the changed bundles of a multi-compiler", () => {
     const compiler = makeFakeCompiler();
     const hot = createHot(compiler, {});