Skip to content

Commit 77f92eb

Browse files
authored
chore(deps): replace on-finished with Node.js built-in stream.finished (#2346)
1 parent 145a228 commit 77f92eb

4 files changed

Lines changed: 9 additions & 16 deletions

File tree

.changeset/plenty-pans-clap.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"webpack-dev-middleware": patch
3+
---
4+
5+
Replace the `on-finished` dependency with Node.js built-in `stream.finished`.

package-lock.json

Lines changed: 2 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@
4848
"dependencies": {
4949
"memfs": "^4.56.10",
5050
"mime-types": "^3.0.2",
51-
"on-finished": "^2.4.1",
5251
"range-parser": "^1.2.1",
5352
"schema-utils": "^4.3.3"
5453
},
@@ -65,7 +64,6 @@
6564
"@types/express": "^5.0.2",
6665
"@types/mime-types": "^3.0.1",
6766
"@types/node": "^22.3.0",
68-
"@types/on-finished": "^2.3.4",
6967
"babel-jest": "^30.1.2",
7068
"connect": "^3.7.0",
7169
"cspell": "^10.0.0",

src/middleware.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
const path = require("node:path");
22
const querystring = require("node:querystring");
3+
const { finished } = require("node:stream");
34

45
const mime = require("mime-types");
5-
const onFinishedStream = require("on-finished");
66

77
const {
88
createReadStreamOrReadFile,
@@ -1122,7 +1122,7 @@ function wrapper(context) {
11221122

11231123
if (outgoing) {
11241124
// Response finished, cleanup
1125-
onFinishedStream(outgoing, (err) => {
1125+
finished(outgoing, (err) => {
11261126
if (err) {
11271127
context.logger.error("Stream error:", err);
11281128
}

0 commit comments

Comments
 (0)