test(e2e): assert linkification on real error messages

The build-error e2e verifies webpack's own "See https://…" becomes a
safe new-tab link (href, target, rel), and the runtime-error e2e keeps
the sentence-ending dot out of the href. The two jsdom linkify tests
are removed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Author: bjohansebas

test/e2e/overlay.test.js

@@ -79,6 +79,24 @@ describe("error overlay (browser)", () => {
 
     expect(text).toContain("Module parse failed");
 
+    // webpack's own "See https://…" is linkified into a safe new-tab link.
+    expect(
+      await frame.evaluate(() => {
+        const link = document.querySelector("a");
+        return (
+          link && {
+            href: link.getAttribute("href"),
+            target: link.getAttribute("target"),
+            rel: link.getAttribute("rel"),
+          }
+        );
+      }),
+    ).toEqual({
+      href: "https://webpack.js.org/concepts#loaders",
+      target: "_blank",
+      rel: "noopener noreferrer",
+    });
+
     hotApp.edit(app("fixed"));
     await waitForNoOverlay(page);
 
@@ -162,13 +180,22 @@ describe("error overlay (browser)", () => {
 
     // The message doubles as an XSS probe: it must render as text.
     await page.evaluate(() => {
-      globalThis.boom('runtime boom <img src=x onerror="window.__xss=1">');
+      globalThis.boom(
+        'runtime boom <img src=x onerror="window.__xss=1"> See https://example.com/a.',
+      );
     });
 
     const frame = await waitForOverlay(page);
     const text = await frame.evaluate(() => document.body.textContent);
 
     expect(text).toContain("runtime boom");
+    // Linkified with the sentence-ending dot kept out of the href.
+    expect(
+      await frame.evaluate(() =>
+        document.querySelector("a")?.getAttribute("href"),
+      ),
+    ).toBe("https://example.com/a");
+    expect(text).toContain("https://example.com/a.");
     expect(
       await frame.evaluate(() => document.querySelector("img") !== null),
     ).toBe(false);

test/overlay.test.js

@@ -75,24 +75,6 @@ describe("overlay", () => {
       expect(findSpanByColor("rgb(255, 107, 107)")).toBeDefined();
     });
 
-    it("turns URLs into links that open in a new tab", () => {
-      showProblems("errors", ["See https://webpack.js.org/concepts#loaders"]);
-      const link = getCard().querySelector("a");
-      expect(link).not.toBeNull();
-      expect(link.getAttribute("href")).toBe(
-        "https://webpack.js.org/concepts#loaders",
-      );
-      expect(link.getAttribute("target")).toBe("_blank");
-      expect(link.getAttribute("rel")).toBe("noopener noreferrer");
-    });
-
-    it("keeps trailing punctuation out of the link href", () => {
-      showProblems("errors", ["Docs: https://example.com/a."]);
-      const link = getCard().querySelector("a");
-      expect(link.getAttribute("href")).toBe("https://example.com/a");
-      expect(getCard().textContent).toContain("https://example.com/a.");
-    });
-
     it("re-mounts the overlay when the iframe was removed without clear()", () => {
       showProblems("errors", ["boom"]);
       // A framework wiping `document.body` removes the iframe behind our back.