fix: convert node readable to web stream in honoWrapper#2315
Merged
alexander-akait merged 4 commits intomainfrom May 7, 2026
Merged
fix: convert node readable to web stream in honoWrapper#2315alexander-akait merged 4 commits intomainfrom
alexander-akait merged 4 commits intomainfrom
Conversation
Wrap the Node fs.ReadStream in a Web ReadableStream we control before handing it to Hono. This routes the response through @hono/node-server's responseViaCache fast path (writeFromReadableStream) and bypasses Node's internal Readable.toWeb adapter, whose late error/close propagation caused intermittent "TypeError: Invalid state: ReadableStream already closed" on Windows + Node 20. All controller transitions are guarded so duplicate end/error events from the underlying fs stream cannot crash the Web stream controller.
Keep src/index.js focused on the wrapper logic and put the node-readable -> web-stream adapter alongside the other stream/response helpers in src/utils.js.
|
|
Track the upstream race so we can drop the helper once honojs/node-server#233 / #299 land and the minimum supported Node version no longer hits the Readable.toWeb adapter bug.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2315 +/- ##
==========================================
- Coverage 93.54% 92.70% -0.84%
==========================================
Files 3 3
Lines 960 1001 +41
Branches 302 311 +9
==========================================
+ Hits 898 928 +30
- Misses 57 65 +8
- Partials 5 8 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap the Node fs.ReadStream in a Web ReadableStream we control before
handing it to Hono. This routes the response through @hono/node-server's
responseViaCache fast path (writeFromReadableStream) and bypasses Node's
internal Readable.toWeb adapter, whose late error/close propagation
caused intermittent "TypeError: Invalid state: ReadableStream already
closed" on Windows + Node 20.
All controller transitions are guarded so duplicate end/error events
from the underlying fs stream cannot crash the Web stream controller.